LPS-83808 Fix versions #66619

izaera · 2019-01-11T08:24:18Z

No description provided.

…in the future

…itional elements that are required by the following logic

…ructor as it should be more common than dependencies

…licated loading boilerplate

…version increases if implementation changes

… an application to affect unrelated applications

… valid value

…kage

liferay-continuous-integration · 2019-01-11T08:24:21Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

izaera · 2019-01-11T08:24:57Z

ci:test

liferay-continuous-integration · 2019-01-11T08:26:57Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 28 seconds 865 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9a92d25f971ad116e2e2cbf969e8c4d3975e15a0

Sender Branch:

Branch Name: pr-70
Branch GIT ID: 36971caa56eaa76744c788ae81f2295a8037559b

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2019-01-11T10:16:31Z

❌ ci:test:relevant - 70 out of 82 jobs passed in 1 hour 48 minutes 10 seconds 680 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9a92d25f971ad116e2e2cbf969e8c4d3975e15a0

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: c6bcdac861d9ba289732a9b62fed33b0f7362d37

70 out of 82 jobs PASSED

12 Failed Jobs:

70 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/11
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #285477
  1. LocalFile.LDAP#ImportLDAPUserWithBlankPassword - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at 9a92d25:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/15
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #212041
  1. LocalFile.Search#ViewSearchResultDetails - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
Job Results:
5 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #260390
  1. LocalFile.Forms#SubmitFormWithAllFieldTypesAndThreePages - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/24
Job Results:
3 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #272928
  1. LocalFile.PGStagingWithVersioning#AddPageVariation - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/27
Job Results:
25 Tests Passed.
3 Tests Failed.
1. AXIS_VARIABLE=1,label_exp=!master #282219
...

liferay-continuous-integration · 2019-01-11T11:20:30Z

❌ ci:test - 155 out of 182 jobs passed in 2 hours 52 minutes 34 seconds 463 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9a92d25f971ad116e2e2cbf969e8c4d3975e15a0

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: c6bcdac861d9ba289732a9b62fed33b0f7362d37

155 out of 182 jobs PASSED

27 Failed Jobs:

155 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mariadb102-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #132357

delete-liferay-home:
   [delete] Deleting directory /opt/dev/projects/github/liferay-portal/bundles/work
   [delete] Deleting directory /tmp/sprite
     [exec] ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/opt/mariadb/data/mariadb.sock' (2)
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:340: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:366: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:9473: exec returned: 1
      [get] Getting: http://test-1-22/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/132357//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20190111101611130.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20190111101611130.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null345444653.properties

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-oracle122-jdk8/1

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #132365

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.felix.fileinstall.internal.DirectoryWatcher.startBundle(DirectoryWatcher.java:1258)
     [exec] 	at org.apache.felix.fileinstall.internal.DirectoryWatcher.startBundles(DirectoryWatcher.java:1230)
     [exec] 	at org.apache.felix.fileinstall.internal.DirectoryWatcher.startAllBundles(DirectoryWatcher.java:1218)
     [exec] 	at org.apache.felix.fileinstall.internal.DirectoryWatcher.doProcess(DirectoryWatcher.java:507)
     [exec] 	at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:361)
     [exec] 	at org.apache.felix.fileinstall.internal.DirectoryWatcher.start(DirectoryWatcher.java:243)
     [exec] 	at org.apache.felix.fileinstall.internal.FileInstall.updated(FileInstall.java:253)
     [exec] 	at org.apache.felix.fileinstall.internal.FileInstall.start(FileInstall.java:130)
     [exec] 	at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:779)
     [exec] 	at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:1)
     [exec] 	at java.security.AccessController.doPrivileged(Native Method)
     [exec] 	at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:772)
     [exec] 	at org.eclipse.osgi.internal.framework.BundleContextImpl.start(BundleContextImpl.java:729)
     [exec] 	at org.eclipse.osgi.internal.framework.EquinoxBundle.startWorker0(EquinoxBundle.java:1002)
     [exec] 	at org.eclipse.osgi.internal.framework.EquinoxBundle$EquinoxModule.startWorker(EquinoxBundle.java:354)
     [exec] 	at org.eclipse.osgi.container.Module.doStart(Module.java:581)
     [exec] 	at org.eclipse.osgi.container.Module.start(Module.java:449)
     [exec] 	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:428)
     [exec] 	at org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:447)
     [exec] 	at com.liferay.portal.bootstrap.ModuleFrameworkImpl$6.call(ModuleFrameworkImpl.java:1565)
     [exec] 	at com.liferay.portal.bootstrap.ModuleFrameworkImpl$6.call(ModuleFrameworkImpl.java:1561)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
     [exec] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
     [exec] 	at java.lang.Thread.run(Thread.java:745)

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mariadb102-jdk8

Job Results:

28 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=7,label_exp=!master #185267

delete-liferay-home:
   [delete] Deleting directory /opt/dev/projects/github/liferay-portal/bundles/work
     [exec] ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/opt/mariadb/data/mariadb.sock' (2)
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:340: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:366: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:9473: exec returned: 1
      [get] Getting: http://test-1-15/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=7,label_exp=!master/185267//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20190111110138989.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20190111110138989.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1087781038.properties

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
Job Results:
10696 Tests Passed.
2 Tests Failed.
1. AXIS_VARIABLE=17,label_exp=!master #269991
  1. PortalLogAssertorTest.testScanXMLLog
  2. PortalLogAssertorTest.testScanOSGiLog

test-portal-acceptance-pullrequest-batch(master)/modules-integration-postgresql10-jdk8

Job Results:

10697 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=10,label_exp=!master #260764

DDMTemplateLocalServiceTest.testSearchByKeywords

org.junit.ComparisonFailure: expected:<[Even]t Template> but was:<[Contac]t Template>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at com.liferay.dynamic.data.mapping.service.test.DDMTemplateLocalServiceTest.testSearchByKeywords(DDMTemplateLocalServiceTest.java:264)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.jboss.arquillian.junit.Arquillian$8$1.invoke(Arquillian.java:370)
	at org.jboss.arquillian.container.test.impl.execution.LocalTestExecuter.execute(LocalTestExecuter.java:60)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.jboss.arquillian.core.impl.ObserverImpl.invoke(ObserverImpl.java:94)
	at org.jboss.arquillian.core.impl.EventContextImpl.invokeObservers(Eve...

...

brianchandotcom · 2019-01-14T05:00:54Z

Merged. Thank you.
View total diff: c2da616...f0ff6aa

brianchandotcom · 2019-01-14T05:01:10Z

@shuyangzhou fyi, you would probably care about this.

@izaera see upstream, minor changes. Thx

shuyangzhou · 2019-01-14T16:00:51Z

@slnn please run a regression test. Thanks!

slnn · 2019-01-15T08:29:26Z

Hi @shuyangzhou

Here are test results for this pull, no noticeable regression appeared.

Login:

Portal Version	Git Id	Session Count	Mean Time of Login	Mean Time of Logout	Drop of Session Count (%)
BaseLine	`e84558d`	47580	288	87.7	-
#66619	-	47355	287	87.2	-0.472887768

Web Content:

Portal Version	Git Id	Session Count	Mean Time of Login	Mean Time of View Page	Drop of Session Count (%)
BaseLine	`e84558d`	62283	549	191	-
#66619	-	61092	557	194	-1.912239295

Message Board:

Portal Version	Git Id	Session Count	Mean Time of Login	Mean Time of Add MB Thread	Drop of Session Count (%)
BaseLine	`e84558d`	15352	19.4	58.4	-
#66619	-	15206	21.7	60	-0.9510161542

Wiki:

Portal Version	Git Id	Session Count	Mean Time of Login	Mean Time of Add Wiki Page	Drop of Session Count (%)
BaseLine	`e84558d`	16373	411	587	-
#66619	-	16022	447	631	-2.143773285

Regards
Lily

shuyangzhou · 2019-01-15T17:39:32Z

Thanks @slnn !

izaera and others added 19 commits January 11, 2019 08:54

LPS-83808 Create an standalone soy renderer

83e462e

LPS-83808 Refactor rendering bootstrap template

c1fd446

LPS-83808 Use SoyRenderer from TemplateRendererTag

ac30ce3

LPS-83808 Create an standalone soy component renderer

9039b98

LPS-83808 Turn renderers into interfaces to minimize semver upgrades …

dc11f3f

…in the future

LPS-83808 Use SoyComponentRenderer from TemplateRendererTag

a052760

LPS-83808 Uses contextCopy since it has been mutated and contains add…

6c9b212

…itional elements that are required by the following logic

LPS-83808 Makes componentId preferred in the ComponentDescripor const…

ecd9fa3

…ructor as it should be more common than dependencies

LPS-83808 Passes all required modules through ScriptData to avoid dup…

4ab33e8

…licated loading boilerplate

LPS-83808 Hides module name logic from public API to minimize future …

dde47cc

…version increases if implementation changes

LPS-83808 Isolates script execution to avoid exceptions thrown inside…

61bb8e4

… an application to affect unrelated applications

LPS-83808 Sets href to empty string as default, as undefined is not a…

ae6cd70

… valid value

LPS-83808 Fix baseline increasing version number of taglib’s OSGi pac…

2817aeb

…kage

LPS-83808 Fix wrapperId generation and enhance internal state handling

b5a1b0d

LPS-83808 Move soy renderers to their own module

9d62dbc

LPS-85962 Propagate commit 466de15 as it was lost with rebase

624a730

LPS-83808 SF

b95dbe6

LPS-83808 Move soy renderer API to its own module to comply with SF

dd3f40e

LPS-83808 Fix versions

36971ca

izaera mentioned this pull request Jan 11, 2019

LPS-83808 DO NOT COMMIT Stores generated randomId to make sure we don't always generate a different one izaera/liferay-portal#70

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Jan 11, 2019

liferay-continuous-integration added ci:test - pending ci:test:relevant - pending and removed ci:test:sf - success ci:test:relevant - pending labels Jan 11, 2019

liferay-continuous-integration added the ci:test:relevant - failure label Jan 11, 2019

liferay-continuous-integration added ci:test - failure and removed ci:test - pending ci:test:relevant - failure labels Jan 11, 2019

brianchandotcom closed this Jan 14, 2019

LPS-83808 Fix versions #66619

LPS-83808 Fix versions #66619

Conversation

izaera commented Jan 11, 2019

liferay-continuous-integration commented Jan 11, 2019

izaera commented Jan 11, 2019

liferay-continuous-integration commented Jan 11, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 28 seconds 865 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 11, 2019

❌ ci:test:relevant - 70 out of 82 jobs passed in 1 hour 48 minutes 10 seconds 680 ms

Base Branch:

Copied in Private Modules Branch:

12 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

liferay-continuous-integration commented Jan 11, 2019

❌ ci:test - 155 out of 182 jobs passed in 2 hours 52 minutes 34 seconds 463 ms

Base Branch:

Copied in Private Modules Branch:

27 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

brianchandotcom commented Jan 14, 2019

brianchandotcom commented Jan 14, 2019

shuyangzhou commented Jan 14, 2019

slnn commented Jan 15, 2019

shuyangzhou commented Jan 15, 2019