Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-90615 New SearchHits API: separate interfaces from implementation #69216

Closed
wants to merge 5 commits into from
Closed

LPS-90615 New SearchHits API: separate interfaces from implementation #69216

wants to merge 5 commits into from

Conversation

arboliveira
Copy link

❌ ci:test:search - 13 out of 17 jobs passed in 1 hour 18 minutes 51 seconds 947 ms
arboliveira#683 (comment)

Branch master is contaminated.

Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/3.55.0/2f3cde95484a93178c781444ca1b31db787f7106/com.liferay.portal.kernel-3.55.0.jar - * com.liferay.asset.kernel.service MINOR 1.8.0 1.8.0 1.9.0 VERSION INCREASE REQUIRED
Unrelated to this pull; no changes made to portal-kernel.

Search#ViewFacetPersistence - Type to 'SEARCH_BAR_WIDGET' the value '*' --> FAILED
Search#NavigateToSearchResultsViaURL - SearchPortlets#selectWidgetScopeInput --> FAILED
https://issues.liferay.com/browse/LPS-91767
Unrelated to this pull. Proper team already aware and investigating.

Search#SearchBlogsEntryCategory - Click on 'CATEGORY_AUTOCOMPLETE_SPECIFIC' --> FAILED
Unrelated to this pull; spotted in other recent pulls. QA investigation underway.

Author: @wcao20170619
Reviewer: @arboliveira

[Story] Top Hits Aggregation
https://issues.liferay.com/browse/LPS-90615

wcao20170619 and others added 5 commits March 8, 2019 16:22
@wcao20170619 @arboliveira
LPS-90615 portal-search-api: add SearchHits interfaces
d14df2f 
https://issues.liferay.com/browse/LPS-90615

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
@wcao20170619 @arboliveira
LPS-90615 portal-search: add SearchHits implementation
c8b159c 
https://issues.liferay.com/browse/LPS-90615

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
@arboliveira @wcao20170619
LPS-90615 portal-search-test-util: use SearchHits interfaces
7769189 
https://issues.liferay.com/browse/LPS-90615

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
@wcao20170619 @arboliveira
LPS-90615 portal-search-elasticsearch6-impl: use SearchHits interfaces
eca841f 
https://issues.liferay.com/browse/LPS-90615

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
@wcao20170619 @arboliveira
LPS-90615 portal-search-elasticsearch6-impl: Test: use SearchHits int…
6fad3fc 
…erfaces

https://issues.liferay.com/browse/LPS-90615

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 35 seconds 910 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bd08f99642d84609ebfc387db66337f525b18ea8

Sender Branch:

Branch Name: LPS-90615-New-SearchHits-subsystem
Branch GIT ID: 6fad3fcd076753df2ecaaba58ca87ea092637cf6

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 22 out of 26 jobs passed in 1 hour 37 minutes 17 seconds 863 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d1ae1827519cac1d18d65418ffb9b240b0b50a25

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: bb05b18168fd1ff84bb232f565de282ff8c473b8

22 out of 26 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #285709

      Startup error: Unresolved Requirement(s)

           [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1585)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:308)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:966)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:839)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1427)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1417)
     [exec] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:943)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:258)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:770)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:682)
     [exec] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

For upstream results, click here.

@brianchandotcom
Copy link
Owner

Merged. Thx.

@arboliveira arboliveira deleted the LPS-90615-New-SearchHits-subsystem branch March 10, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
4 participants
@arboliveira @liferay-continuous-integration @brianchandotcom @wcao20170619