LPS-93362 Fix built themes pulling in wrong version of clay-css dependency #70786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency
Instead of relying on the stale snapshots of
liferay-frontend-theme-styled and liferay-frontend-theme-unstyled, which
pull in an old version of clay-css, always use the in-repo versions
directly.
Test plan:
See that all themes build and deploy, ie. in "modules/apps/", run:
for X in admin classic; do
(cd frontend-theme/frontend-theme-$X && gradlew clean deploy)
done
for X in fjord westeros-bank porygon; do
(cd frontend-theme-$X/frontend-theme-$X && gradlew clean deploy)
done
And see these lines in the build output:
Files of project ':apps:frontend-theme:frontend-theme-admin' deployed to /Users/greghurrell/code/portal/bundles/deploy
Files of project ':apps:frontend-theme:frontend-theme-classic' deployed to /Users/greghurrell/code/portal/bundles/osgi/war
Files of project ':apps:frontend-theme-fjord:frontend-theme-fjord' deployed to /Users/greghurrell/code/portal/bundles/deploy
Files of project ':apps:frontend-theme-westeros-bank:frontend-theme-westeros-bank' deployed to /Users/greghurrell/code/portal/bundles/deploy
Files of project ':apps:frontend-theme-porygon:frontend-theme-porygon' deployed to /Users/greghurrell/code/portal/bundles/deploy<Paste>
Look at portal and see header font has reverted to previous, desired
size. Note that the yarn.lock no longer pulls in the old clay-css.
|
Great, thanks @wincent! 👍 |
|
ci:test-sf |
|
ci:test-relevant |
liferay-continuous-integration
added
ci:test - pending
and removed
ci:test - pending
labels
This was referenced Apr 4, 2019
|
ci:stop |
liferay-continuous-integration
added
ci:test - failure
and removed
ci:test - pending
labels
❌ ci:test - 0 out of 1 jobs passed in 53 minutes 45 seconds 873 msClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 1 Failed Jobs:For more details click here.Failures unique to this pull:For upstream results, click here. |
The pull request tester is still running.Please wait until you get the final report before running 'ci:retest'. See this link to check on the status of your test: However, the pull request was closed.The pull request was closed because the following critical batches had failed: For information as to why we automatically close out certain pull requests see this article. *This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment. ci:reopen Critical Failure Details:test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8Job Results:4744 Tests Passed.
cc @
|
liferay-continuous-integration
added
ci:test - failure
and removed
ci:test - failure
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the stale snapshots of liferay-frontend-theme-styled and liferay-frontend-theme-unstyled, which pull in an old version of clay-css, always use the in-repo versions directly.
Test plan:
See that all themes build and deploy, ie. in "modules/apps/", run:
And see these lines in the build output:
Look at portal and see header font has reverted to previous, desired size. Note that the yarn.lock no longer pulls in the old clay-css. Also, create three sites with the three marketplaces themes (porygon, westeros-bank and fjord) and see them all render correctly.
cc: @jbalsas