Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-94408 Uses vertical card on configuration #71964

Closed
wants to merge 11 commits into from
Closed

LPS-94408 Uses vertical card on configuration #71964

wants to merge 11 commits into from

Conversation

ealonso
Copy link

@ealonso ealonso commented Apr 22, 2019

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@ealonso
Copy link
Author

ealonso commented Apr 22, 2019

cc: @pavel-savinov

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 58 seconds 862 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6d452c184a47e690ccfc994f07872d8f024f6871

Sender Branch:

Branch Name: LPS-94408
Branch GIT ID: 0649f1df711d240f2169e98122d5877b437d0556

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 23 out of 29 jobs passed in 56 minutes 52 seconds 13 ms

Click here for more details.

Base Branch:

Branch Name: master

Copied in Private Modules Branch:

Branch Name:

23 out of 29 jobs PASSED
23 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
    Job Results:

    2 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #249827
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
{code="404", msg="ProxyServlet: /o/admin-theme/images/lexicon/icons.svg", uri=/o/admin-theme/images/lexicon/icons.svg}
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:172)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
  2. test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
    Job Results:

    2 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #202693
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
{code="404", msg="ProxyServlet: /o/admin-theme/images/clay/icons.svg", uri=/o/admin-theme/images/clay/icons.svg}
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:172)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
  5. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8
    Job Results:

    4 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #251555
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
{code="404", msg="ProxyServlet: /o/admin-theme/images/clay/icons.svg", uri=/o/admin-theme/images/clay/icons.svg}
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:172)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

For upstream results, click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: e393f91...947ee7c

@brianchandotcom
Copy link
Owner

@ealonso we have JournalSelectDDMTemplate and SelectJournalDDMTemplate (I find it a bit weird)

Please fix if possible. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
3 participants
@ealonso @liferay-continuous-integration @brianchandotcom