LPS-95357 Extract upgrade methods from OAuth2ServiceUpgrade to util in upgrade module

[topolik]

Hi Brian,

follow up of #72823 (comment)

2.) I like getAddColumnsUpgradeProcess, getDropColumnsUpgradeProcess, and getRunSQLUpgradeProcess. Can you move it to a factory/util/builder in com.liferay.portal.upgrade so that everyone can start copying your pattern? Feel free to rename the methods to make it fit your new factory/util/builder.

/cc @csierra

Did you mean portal-kernel or this portal-upgrade-api module? Also it's in API module but contains reference to UpgradeProcess which is actually an impl.

Thanks.

[liferay-continuous-integration]

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 34 seconds 185 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e622fbb7dd8cca0548a1afd8de7146666af6f4a0

Sender Branch:

Branch Name: pull-request-759-LPS-95357
Branch GIT ID: 725563d2713343d92bbcc4682a3b612ad42d2677

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

❌ ci:test:relevant - 24 out of 26 jobs passed in 1 hour 28 minutes 53 seconds 639 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e622fbb7dd8cca0548a1afd8de7146666af6f4a0

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: da67ed2286f3e7529b7c658abd1554cb1974ace3

24 out of 26 jobs PASSED

2 Failed Jobs:

• test-portal-acceptance-pullrequest(master)
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

24 Successful Jobs:

• test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/1
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/2
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/3
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/4
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/5
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/6
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/7
• test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8
• test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8
• test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8
• test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8
• test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
• test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

For more details click here.

---

This pull contains no unique failures.

---

Failures in common with acceptance upstream results at e622fbb:

1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

   Job Results:

   214 Tests Passed.
   1 Test Failed.

   1. AXIS_VARIABLE=0,label_exp=!master #164782

      1. ProjectTemplatesTest.testCompareGradlePluginVersions

         org.junit.ComparisonFailure: com.liferay.plugin versions do not match expected:<3.13.19[5]> but was:<3.13.19[6]>
         	at org.junit.Assert.assertEquals(Assert.java:115)
         	at com.liferay.project.templates.ProjectTemplatesTest.testCompareGradlePluginVersions(ProjectTemplatesTest.java:4068)
         	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
         	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
         	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
         	at java.lang.reflect.Method.invoke(Method.java:498)
         	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
         	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
         	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
         	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
         	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
         	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
         	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
         	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
         	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
         	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
         	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
         	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
         	at o...

[brianchandotcom]

Merged. Thank you.
View total diff: 1097770...b7a8885

[brianchandotcom]

@topolik beautiful

[Preston-Crary]

@csierra @topolik this causes SplitPackagesTest to fail on upstream because portal-impl is exporting the same package: com.liferay.portal.upgrade.util.

@michaelhashimoto why is there no test results for unit-jdk8 even though it's listed in test.batch.names[relevant]? I think there's an off by one bug where we're reading this property since it's the last one.

[csierra]

please see #73447