Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-95409 Add languageId parameter so that CSSs are reloaded by senna #73533

Closed
wants to merge 1 commit into from

Conversation

izaera
Copy link

@izaera izaera commented May 22, 2019

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@izaera
Copy link
Author

izaera commented May 22, 2019

ci:test

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 10 seconds 454 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ce4f1a8dd8512fb143a3d47659f65873e5e88993

Sender Branch:

Branch Name: LPS-95409
Branch GIT ID: 74be220f772719d68aa5a8448dfae2e197eb374a

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test - 0 out of 1 jobs passed in 9 minutes 28 seconds 760 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ce4f1a8dd8512fb143a3d47659f65873e5e88993

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 262583b27c5d62a3bf588793dd1ca7d1ed3c8c05

0 out of 1 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    1 Job Failed.

         [exec] * What went wrong:
         [exec] A problem occurred configuring project ':private:apps:portal-workflow:portal-workflow-metrics-web'.
         [exec] > Version in package-lock.json must match project version
         [exec] 
         [exec] * Try:
         [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
         [exec] 
         [exec] * Exception is:
         [exec] org.gradle.api.ProjectConfigurationException: A problem occurred configuring project ':private:apps:portal-workflow:portal-workflow-metrics-web'.
         [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.wrapException(LifecycleProjectEvaluator.java:79)
         [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.addConfigurationFailure(LifecycleProjectEvaluator.java:73)
         [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.access\$400(LifecycleProjectEvaluator.java:54)
         [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator\$NotifyAfterEvaluate.run(LifecycleProjectEvaluator.java:200)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:300)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:292)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:174)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
         [exec] 	at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
         [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator\$EvaluateProject.run(LifecycleProjectEvaluator.java:110)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:300)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:292)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:174)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)

For upstream results, click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 0 out of 1 jobs passed in 11 minutes 49 seconds 608 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ce4f1a8dd8512fb143a3d47659f65873e5e88993

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 262583b27c5d62a3bf588793dd1ca7d1ed3c8c05

0 out of 1 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    1 Job Failed.

         [exec] * What went wrong:
         [exec] A problem occurred configuring project ':private:apps:portal-workflow:portal-workflow-metrics-web'.
         [exec] > Version in package-lock.json must match project version
         [exec] 
         [exec] * Try:
         [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
         [exec] 
         [exec] * Exception is:
         [exec] org.gradle.api.ProjectConfigurationException: A problem occurred configuring project ':private:apps:portal-workflow:portal-workflow-metrics-web'.
         [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.wrapException(LifecycleProjectEvaluator.java:79)
         [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.addConfigurationFailure(LifecycleProjectEvaluator.java:73)
         [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.access\$400(LifecycleProjectEvaluator.java:54)
         [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator\$NotifyAfterEvaluate.run(LifecycleProjectEvaluator.java:200)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:300)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:292)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:174)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
         [exec] 	at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
         [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator\$EvaluateProject.run(LifecycleProjectEvaluator.java:110)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:300)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:292)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:174)
         [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)

For upstream results, click here.

@jpince
Copy link
Collaborator

jpince commented May 22, 2019

ci:test:wem-msb

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:wem-msb - 0 out of 1 jobs passed in 18 minutes 37 seconds 109 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ea4978fd20192a92ee3d0113e55024c4e96dc2ec

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: c896f7ce7f68c08c2dff2c655cf3a4e67ac7ac3c

0 out of 1 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    1 Job Failed.

    A CI failure has occurred. QA Engineering has been notified. Please try again later or contact QA Engineering for an update.

For upstream results, click here.

@pyoo47
Copy link

pyoo47 commented May 22, 2019

The CI test suite 'wem-msb' is not a valid test suite.

@jpince
Copy link
Collaborator

jpince commented May 22, 2019

@brianchiu @kyle-miho has the wem-msb test suite worked before? Not sure if it just needs to be added to ci.properties?

@jpince
Copy link
Collaborator

jpince commented May 22, 2019

ci:test:relevant

@kyle-miho
Copy link

@jpince it worked a month ago
brianchiu#1870

@pyoo47
Copy link

pyoo47 commented May 22, 2019

@kyle-miho We recently added some validation logic to check whether or not the test-suite name provided is valid. Prior to that, using an invalid test-suite name would just trigger the default test-suite. The test that ran in brianchiu#1870 was most likely just the default test.

CC:@yichenroy

@yichenroy
Copy link

@jpince @kyle-miho
The suite validation checks ci.properties for a list of valid suites. Jason is right, if the suite worked before then you just need to make sure the name is also added to ci.properties when you add/test the new suite.

cc @pyoo47

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 18 out of 21 jobs passed in 1 hour 10 minutes 30 seconds 53 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ea4978fd20192a92ee3d0113e55024c4e96dc2ec

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: c896f7ce7f68c08c2dff2c655cf3a4e67ac7ac3c

18 out of 21 jobs PASSED
18 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
    Job Results:

    6 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #301863
      1. ModulesStructureTest.testScanBuildScripts
        junit.framework.AssertionFailedError: Missing modules/private/apps/portal-store-manta/build.gradle
        	at com.liferay.portal.modules.util.ModulesStructureTestUtil.read(ModulesStructureTestUtil.java:93)
        	at com.liferay.portal.modules.ModulesStructureTest._testEquals(ModulesStructureTest.java:912)
        	at com.liferay.portal.modules.ModulesStructureTest.access$300(ModulesStructureTest.java:66)
        	at com.liferay.portal.modules.ModulesStructureTest$1.preVisitDirectory(ModulesStructureTest.java:185)
        	at com.liferay.portal.modules.ModulesStructureTest$1.preVisitDirectory(ModulesStructureTest.java:122)
        	at java.nio.file.Files.walkFileTree(Files.java:2677)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.modules.ModulesStructureTest.testScanBuildScripts(ModulesStructureTest.java:120)
        
  2. test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #256097
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:frontend-taglib:frontend-taglib-clay:npmRunTest'.
           [exec] > java.io.IOException: Process '[/opt/dev/projects/github/liferay-portal/build/node/bin/node, /opt/dev/projects/github/liferay-portal/modules/yarn-1.13.0.js, --production, false, --registry, http://mirrors.lax.liferay.com:4873, run, test]' finished with non-zero exit value 1
           [exec] 
           [exec] * Try:
           [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:frontend-taglib:frontend-taglib-clay:npmRunTest'.
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
           [exec] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
           [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
           [exec] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
           [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

For upstream results, click here.

@brianchandotcom
Copy link
Owner

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants