Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-96149 Ensure destructor method is called to remove any remaining handler #73914

Closed
wants to merge 2 commits into from
Closed

LPS-96149 Ensure destructor method is called to remove any remaining handler #73914

wants to merge 2 commits into from

Conversation

jeyvison
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 58 seconds 328 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 225c659eaf111dc02a4b94917e1e2195293d56e3

Sender Branch:

Branch Name: pr-389
Branch GIT ID: 22ceff3119a016ba8294e4fda714b9289c774921

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 30 out of 32 jobs passed in 59 minutes 44 seconds 289 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 29a9f4f513ad5ab067dd12aa93d158735ca36f2b

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: f56c12259eedd09aad0672c153c75d521c606186

30 out of 32 jobs PASSED
30 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 225c659:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    1690 Tests Passed.
    4 Tests Failed.

    1. AXIS_VARIABLE=2,label_exp=!master #257623
      1. StructuredContentResourceTest.testGetContentStructureStructuredContentsPageWithFilterDateTimeEquals
        java.lang.IllegalArgumentException: Expected starts with '{', but found 'H' in 'HTTP 500 Internal Server Error'
	at com.liferay.headless.delivery.client.json.BaseJSONParser._assertStartsWithAndEndsWith(BaseJSONParser.java:260)
	at com.liferay.headless.delivery.client.json.BaseJSONParser.parseToDTO(BaseJSONParser.java:45)
	at com.liferay.headless.delivery.client.pagination.Page.of(Page.java:39)
	at com.liferay.headless.delivery.client.resource.v1_0.StructuredContentResource.getContentStructureStructuredContentsPage(StructuredContentResource.java:54)
	at com.liferay.headless.delivery.resource.v1_0.test.BaseStructuredContentResourceTestCase.testGetContentStructureStructuredContentsPageWithFilterDateTimeEquals(BaseStructuredContentResourceTestCase.java:234)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$2.evaluate(TestExecutorRunnable.java:206)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(...
      2. StructuredContentResourceTest.testGetContentStructureStructuredContentsPageWithFilterStringEquals
        java.lang.IllegalArgumentException: Expected starts with '{', but found 'H' in 'HTTP 500 Internal Server Error'
	at com.liferay.headless.delivery.client.json.BaseJSONParser._assertStartsWithAndEndsWith(BaseJSONParser.java:260)
	at com.liferay.headless.delivery.client.json.BaseJSONParser.parseToDTO(BaseJSONParser.java:45)
	at com.liferay.headless.delivery.client.pagination.Page.of(Page.java:39)
	at com.liferay.headless.delivery.client.resource.v1_0.StructuredContentResource.getContentStructureStructuredContentsPage(StructuredContentResource.java:54)
	at com.liferay.headless.delivery.resource.v1_0.test.BaseStructuredContentResourceTestCase.testGetContentStructureStructuredContentsPageWithFilterStringEquals(BaseStructuredContentResourceTestCase.java:272)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$2.evaluate(TestExecutorRunnable.java:206)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(Ab...
      3. StructuredContentResourceTest.testGetContentStructureStructuredContentsPageWithSortDateTime
        java.lang.IllegalArgumentException: Expected starts with '{', but found 'H' in 'HTTP 500 Internal Server Error'
	at com.liferay.headless.delivery.client.json.BaseJSONParser._assertStartsWithAndEndsWith(BaseJSONParser.java:260)
	at com.liferay.headless.delivery.client.json.BaseJSONParser.parseToDTO(BaseJSONParser.java:45)
	at com.liferay.headless.delivery.client.pagination.Page.of(Page.java:39)
	at com.liferay.headless.delivery.client.resource.v1_0.StructuredContentResource.getContentStructureStructuredContentsPage(StructuredContentResource.java:54)
	at com.liferay.headless.delivery.resource.v1_0.test.BaseStructuredContentResourceTestCase.testGetContentStructureStructuredContentsPageWithSortDateTime(BaseStructuredContentResourceTestCase.java:369)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$2.evaluate(TestExecutorRunnable.java:206)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:79)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(Abstract...
      4. ...

@jpince
Copy link
Collaborator

jpince commented May 30, 2019

@dacousalr @jkappler @jeyvison at first glance, I was concerned... 😨 🤣
image
But the test results look good 👍

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 6d77ea6...bc74d68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
5 participants
@jeyvison @liferay-continuous-integration @jpince @brianchandotcom @dacousalr