LPS-99963 Ternary check not needed

[bryceosterhaus]

No description provided.

[liferay-continuous-integration]

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 1 second 868 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f2b99b27da420bc127835574847a64e1095d06eb

Sender Branch:

Branch Name: pr-58
Branch GIT ID: 2b231bcf3639d89a90ba8d227d0ea2b6ec964ac9

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 39 seconds 246 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f2b99b27da420bc127835574847a64e1095d06eb

Sender Branch:

Branch Name: pr-58
Branch GIT ID: 2b231bcf3639d89a90ba8d227d0ea2b6ec964ac9

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

❌ ci:test:relevant - 15 out of 17 jobs passed in 1 hour 9 minutes 21 seconds 994 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f2b99b27da420bc127835574847a64e1095d06eb

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 186e3c335667f7d5c611b805cea1b29f92b7fe8c

15 out of 17 jobs PASSED

2 Failed Jobs:

• test-portal-acceptance-pullrequest(master)
• test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8

15 Successful Jobs:

• test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/1
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/2
• test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8
• test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
• test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8
• test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
• test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

For more details click here.

---

Failures unique to this pull:

1. test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8

   Job Results:

   0 Tests Passed.
   1 Test Failed.

   1. AXIS_VARIABLE=0,label_exp=!master #263205

           [exec] * What went wrong:
           [exec] Execution failed for task ':private:apps:portal-workflow:portal-workflow-metrics-web:packageRunTest'.
           [exec] > java.io.IOException: Process '[/opt/dev/projects/github/liferay-portal/build/node/bin/node, /opt/dev/projects/github/liferay-portal/modules/yarn-1.13.0.js, --production, false, --registry, http://mirrors.lax.liferay.com:4873, run, test]' finished with non-zero exit value 1
           [exec] 
           [exec] * Try:
           [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':private:apps:portal-workflow:portal-workflow-metrics-web:packageRunTest'.
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
           [exec] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
           [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
           [exec] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
           [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
           [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
           [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

For upstream results, click here.

[brianchandotcom]

Merged. Thank you.
View total diff: 0c71b93...a51a4c5