LPS-102998 Add a way for users to locally store generic private repo … #79365

CAustin582 · 2019-10-09T22:46:29Z

…credentials

liferay-continuous-integration · 2019-10-09T22:46:34Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2019-10-09T22:50:46Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes 247 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8c1c6fef4d4603df776cbb2b0c386bffca2e2e18

Sender Branch:

Branch Name: LPS-102998
Branch GIT ID: b8620a0d7dac20b2884f42f9bd08e38a211f3af1

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2019-10-09T23:52:42Z

❌ ci:test:relevant - 13 out of 17 jobs passed in 1 hour 5 minutes 51 seconds 840 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6b0732d72b4042ab02c080305327a16c83135ba5

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: b5195863bcee960d1395e0db859227579556ebf3

13 out of 17 jobs PASSED

4 Failed Jobs:

13 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
Job Results:
2 Tests Passed.
2 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #346201
  1. PortalLogAssertorTest.testScanXMLLog
  2. LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

2 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #340803

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Unable to register portal instance {mvccVersion=1, companyId=20095, accountId=20097, webId=liferay.com, key=3GikYYBY1jKSTTwTX0a9FQ==, mx=liferay.com, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
java.lang.NullPointerException
	at com.liferay.exportimport.internal.staging.StagingImpl.addModelToChangesetCollection(StagingImpl.java:232)
	at com.liferay.staging.internal.model.listener.StagingModelListenerImpl.onAfterCreate(StagingModelListenerImpl.java:43)
	at com.liferay.layout.admin.web.internal.model.listener.LayoutPageTemplateEntryStagingModelListener.onAfterCreate(LayoutPageTemplateEntryStagingModelListener.java:37)
	at com.liferay.layout.admin.web.internal.model.listener.LayoutPageTemplateEntryStagingModelListener.onAfterCreate(LayoutPageTemplateEntryStagingModelListener.java:29)
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.update(BasePersistenceImpl.java:548)
	at com.liferay.layout.page.template.service.impl.LayoutPageTemplateEntryLocalServiceImpl.addLayoutPageTemplateEntry(LayoutPageTemplateEntryLocalServiceImpl.java:188)
	at com.liferay.layout.page.template.service.impl.LayoutPageTemplateEntryLocalServiceImpl.addLayoutPageTemplateEntry(LayoutPageTemplateEntryLocalServiceImpl.java:815)
	at com.liferay.layout.page.template.service.impl.LayoutPageTemplateEntryLocalServiceImpl.addLayoutPageTemplateEntry(LayoutPageTemplateEntryLocalServiceImpl.java:108)
	at com.liferay.portal.spring.aop.AopM...

LocalFile.PortalSmoke#Smoke - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at 0dc6fe5:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

375 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=1,label_exp=!master #340804
1. PortalLogAssertorTest.testScanXMLLog

AXIS_VARIABLE=2,label_exp=!master #340804

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Unable to register portal instance {mvccVersion=1, companyId=20096, accountId=20098, webId=liferay.com, key=9VvRY3zqVd5+5fJxX+J9mA==, mx=liferay.com, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
java.lang.NullPointerException
	at com.liferay.exportimport.internal.staging.StagingImpl.addModelToChangesetCollection(StagingImpl.java:232)
	at com.liferay.staging.internal.model.listener.StagingModelListenerImpl.onAfterCreate(StagingModelListenerImpl.java:43)
	at com.liferay.layout.admin.web.internal.model.listener.LayoutPageTemplateEntryStagingModelListener.onAfterCreate(LayoutPageTemplateEntryStagingModelListener.java:37)
	at com.liferay.layout.admin.web.internal.model.listener.LayoutPageTemplateEntryStagingModelListener.onAfterCreate(LayoutPageTemplateEntryStagingModelListener.java:29)
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.update(BasePersistenceImpl.java:548)
	at com.liferay.layout.page.template.service.impl.LayoutPageTemplateEntryLocalServiceImpl.addLayoutPageTemplateEntry(LayoutPageTemplateEntryLocalServiceImpl.java:188)
	at com.liferay.layout.page.template.service.impl.LayoutPageTemplateEntryLocalServiceImpl.addLayoutPageTemplateEntry(LayoutPageTemplateEntryLocalServiceImpl.java:815)
	at com.liferay.layout.page.template.service.impl.LayoutPageTemplateEntryLocalServiceImpl.addLayoutPageTemplateEntry(LayoutPageTemplateEntryLocalServiceImpl.java:108)
	at com.liferay.portal.spring.aop.AopM...

CAustin582 · 2019-10-10T00:36:52Z

ci:test:relevant

liferay-continuous-integration · 2019-10-10T01:53:54Z

❌ ci:test:relevant - 15 out of 17 jobs passed in 1 hour 15 minutes 59 seconds 675 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6b0732d72b4042ab02c080305327a16c83135ba5

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: b5195863bcee960d1395e0db859227579556ebf3

15 out of 17 jobs PASSED

2 Failed Jobs:

15 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 6b0732d:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

376 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=1,label_exp=!master #224115

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Unable to register portal instance {mvccVersion=1, companyId=20096, accountId=20098, webId=liferay.com, key=DUV9DuahwDQlbkjkkjMSqw==, mx=liferay.com, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
java.lang.NullPointerException
	at com.liferay.exportimport.internal.staging.StagingImpl.addModelToChangesetCollection(StagingImpl.java:232)
	at com.liferay.staging.internal.model.listener.StagingModelListenerImpl.onAfterCreate(StagingModelListenerImpl.java:43)
	at com.liferay.layout.admin.web.internal.model.listener.LayoutPageTemplateEntryStagingModelListener.onAfterCreate(LayoutPageTemplateEntryStagingModelListener.java:37)
	at com.liferay.layout.admin.web.internal.model.listener.LayoutPageTemplateEntryStagingModelListener.onAfterCreate(LayoutPageTemplateEntryStagingModelListener.java:29)
	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.update(BasePersistenceImpl.java:548)
	at com.liferay.layout.page.template.service.impl.LayoutPageTemplateEntryLocalServiceImpl.addLayoutPageTemplateEntry(LayoutPageTemplateEntryLocalServiceImpl.java:188)
	at com.liferay.layout.page.template.service.impl.LayoutPageTemplateEntryLocalServiceImpl.addLayoutPageTemplateEntry(LayoutPageTemplateEntryLocalServiceImpl.java:815)
	at com.liferay.layout.page.template.service.impl.LayoutPageTemplateEntryLocalServiceImpl.addLayoutPageTemplateEntry(LayoutPageTemplateEntryLocalServiceImpl.java:108)
	at com.liferay.portal.spring.aop.AopM...

topolik · 2019-10-10T16:15:45Z

Hi @CAustin582,

1, Can this be improved to support credentials rotation? E.g. have some public https://files.liferay.com/.DXP_CREDENTIALS.sha512 file with a fingerprint of the private file content and if it doesn't match then ask again to download it?

2, Instead of asking the username & password from a command line, can we instruct user to open the file in a browser and download to a proper place? I don't trust cmd line, it shows password and password manager talks to browsers better.

Thanks.

topolik · 2019-10-10T16:59:22Z

Btw. the best solution would be to have okta integration with nexus. Then we could auto-provision user accounts into nexus and rely on OAuth2 instead of user credentials.

This way when the .DXP_CREDENTIALS leaks (forgotten/stolen) laptop we would not need to rotate it for every developer, just rotate one user access token.

Just saying.

jpince · 2019-10-10T18:05:23Z

BChan said he will work with @petershin on Monday (Oct 14) on option #1 that @topolik suggested

CAustin582 · 2019-10-10T18:44:20Z

@topolik

Sure, we can do something like that
This script will not display your password in the command line

CAustin582 · 2019-10-10T22:02:19Z

ci:test:relevant

liferay-continuous-integration · 2019-10-10T23:05:51Z

❌ ci:test:relevant - 15 out of 17 jobs passed in 1 hour 3 minutes 8 seconds 281 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9c680c0a02b50901e6ea7b13c295aa4a8cbff92e

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 9abff772ffeb60a7160eae44aedcfcbc7b3a3f6d

15 out of 17 jobs PASSED

2 Failed Jobs:

15 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 1f7c579:

test-portal-acceptance-pullrequest-batch(master)/unit-jdk8

Job Results:

2745 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #341122

LibraryReferenceTest.testLibJarsInEclipse

junit.framework.AssertionFailedError: .classpath is missing a reference to lib/portal/ant-compress.jar
	at com.liferay.portal.library.LibraryReferenceTest.testMissingJarReferences(LibraryReferenceTest.java:231)
	at com.liferay.portal.library.LibraryReferenceTest.testLibJarsInEclipse(LibraryReferenceTest.java:147)

LibraryReferenceTest.testLibJarsInNetBeans

junit.framework.AssertionFailedError: nbproject/project.properties is missing a reference to lib/portal/ant-compress.jar
	at com.liferay.portal.library.LibraryReferenceTest.testMissingJarReferences(LibraryReferenceTest.java:231)
	at com.liferay.portal.library.LibraryReferenceTest.testLibJarsInNetBeans(LibraryReferenceTest.java:152)

CAustin582 · 2019-10-10T23:40:59Z

ci:test:relevant

liferay-continuous-integration · 2019-10-11T01:07:55Z

❌ ci:test:relevant - 15 out of 17 jobs passed in 1 hour 19 minutes 16 seconds 683 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d3be318e1075f0943b668a036605358c26c3eab9

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 9abff772ffeb60a7160eae44aedcfcbc7b3a3f6d

15 out of 17 jobs PASSED

2 Failed Jobs:

15 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 1f7c579:

test-portal-acceptance-pullrequest-batch(master)/unit-jdk8

Job Results:

2745 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #283689

LibraryReferenceTest.testLibJarsInEclipse

junit.framework.AssertionFailedError: .classpath is missing a reference to lib/portal/ant-compress.jar
	at com.liferay.portal.library.LibraryReferenceTest.testMissingJarReferences(LibraryReferenceTest.java:231)
	at com.liferay.portal.library.LibraryReferenceTest.testLibJarsInEclipse(LibraryReferenceTest.java:147)

LibraryReferenceTest.testLibJarsInNetBeans

junit.framework.AssertionFailedError: nbproject/project.properties is missing a reference to lib/portal/ant-compress.jar
	at com.liferay.portal.library.LibraryReferenceTest.testMissingJarReferences(LibraryReferenceTest.java:231)
	at com.liferay.portal.library.LibraryReferenceTest.testLibJarsInNetBeans(LibraryReferenceTest.java:152)

brianchandotcom · 2019-10-15T23:46:24Z

@CAustin582 we found a different way to do this.. @petershin has more details.

LPS-102998 Add a way for users to locally store generic private repo …

b8620a0

…credentials

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:sf - success and removed ci:test:sf - pending labels Oct 9, 2019

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Oct 9, 2019

liferay-continuous-integration added ci:test:relevant - pending ci:test:relevant - failure and removed ci:test:relevant - failure ci:test:relevant - pending labels Oct 10, 2019

liferay-continuous-integration added ci:test:relevant - pending and removed ci:test:relevant - failure ci:test:relevant - pending labels Oct 10, 2019

liferay-continuous-integration added the ci:test:relevant - failure label Oct 11, 2019

brianchandotcom closed this Oct 15, 2019

jpince mentioned this pull request Oct 22, 2019

LPS-103170 Add task setup-profile-dxp #79600

Closed

LPS-102998 Add a way for users to locally store generic private repo … #79365

LPS-102998 Add a way for users to locally store generic private repo … #79365

Conversation

CAustin582 commented Oct 9, 2019

liferay-continuous-integration commented Oct 9, 2019

liferay-continuous-integration commented Oct 9, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes 247 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 9, 2019

❌ ci:test:relevant - 13 out of 17 jobs passed in 1 hour 5 minutes 51 seconds 840 ms

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

CAustin582 commented Oct 10, 2019

liferay-continuous-integration commented Oct 10, 2019

❌ ci:test:relevant - 15 out of 17 jobs passed in 1 hour 15 minutes 59 seconds 675 ms

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

topolik commented Oct 10, 2019

topolik commented Oct 10, 2019

jpince commented Oct 10, 2019

CAustin582 commented Oct 10, 2019

CAustin582 commented Oct 10, 2019

liferay-continuous-integration commented Oct 10, 2019

❌ ci:test:relevant - 15 out of 17 jobs passed in 1 hour 3 minutes 8 seconds 281 ms

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/unit-jdk8

Job Results:

CAustin582 commented Oct 10, 2019

liferay-continuous-integration commented Oct 11, 2019

❌ ci:test:relevant - 15 out of 17 jobs passed in 1 hour 19 minutes 16 seconds 683 ms

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/unit-jdk8

Job Results:

brianchandotcom commented Oct 15, 2019