LPS-102718 Dispose floating toolbar inside requestAnimationFrame #80083

sandrodw3 · 2019-10-28T14:58:27Z

No description provided.

Should fix the related LPS-102718 ("Tooltip does not disappear and keep position when scrolling") and some similar issues caused by a missing editor context on the "spacing" button. Full release notes: https://github.com/liferay/alloy-editor/releases/tag/v2.11.1

liferay-continuous-integration · 2019-10-28T14:58:33Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

sandrodw3 · 2019-10-28T14:59:27Z

/cc @jbalsas @wincent @p2kmgcl

liferay-continuous-integration · 2019-10-28T15:01:26Z

✔️ ci:test:ci:test:sf - 1 out of 1 jobs passed in 2 minutes 42 seconds 531 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 988535d4550b521f4d6766a6ff213adb5c4309ed

Sender Branch:

Branch Name: pr-147
Branch GIT ID: 7a9acf094a9c0f4757fe22c2fd4cbcef697e4b4d

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2019-10-28T16:22:57Z

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 18 out of 25 jobs passed in 1 hour 23 minutes 32 seconds 920 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5ac6ae19ca00eb455194dd26991db70ba58363cd

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: ed97ba4633ca1f030519ac365e520b1d4ae3def5

ci:test:stable - 8 out of 9 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8~~

8 Successful Jobs:

ci:test:relevant - 18 out of 25 jobs PASSED

7 Failed Jobs:

18 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
8 Tests Passed.
2 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #198707
  1. LocalFile.ContentPagesWithContributedFragments#AddContentPageWithVideoFragment - Poshi Report - Poshi Summary - Console Output
  2. LocalFile.ContentPagesWithEditables#AddContentPageWithHTMLFragment - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #351112

     [echo] 	at java.lang.ref.Reference.tryHandlePending(Reference.java:191)
     [echo] 	- locked <0x00000000820247e0> (a java.lang.ref.Reference$Lock)
     [echo] 	at java.lang.ref.Reference$ReferenceHandler.run(Reference.java:153)
     [echo] 
     [echo]    Locked ownable synchronizers:
     [echo] 	- None
     [echo] 
     [echo] "main" #1 prio=5 os_prio=0 tid=0x00007fc57800b000 nid=0x173f runnable [0x00007fc581cb3000]
     [echo]    java.lang.Thread.State: RUNNABLE
     [echo] 	at java.net.PlainSocketImpl.socketAccept(Native Method)
     [echo] 	at java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:409)
     [echo] 	at java.net.ServerSocket.implAccept(ServerSocket.java:545)
     [echo] 	at java.net.ServerSocket.accept(ServerSocket.java:513)
     [echo] 	at org.apache.catalina.core.StandardServer.await(StandardServer.java:607)
     [echo] 	at org.apache.catalina.startup.Catalina.await(Catalina.java:722)
     [echo] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:668)
     [echo] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [echo] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [echo] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [echo] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [echo] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [echo] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)
     [echo] 
     [echo]    Locked ownable synchronizers:
     [echo] 	- None
     [echo] 
     [echo] "VM Thread" os_prio=0 tid=0x00007fc57809a800 nid=0x1742 runnable 
     [echo] 
     [echo] "Gang worker#0 (Parallel GC Threads)" os_prio=0 tid=0x00007fc57801c000 nid=0x1740 runnable 
     [echo] 
     [echo] "Gang worker#1 (Parallel GC Threads)" os_prio=0 tid=0x00007fc57801e000 nid=0x1741 runnable 
     [echo] 
     [echo] "VM Periodic Task Thread" os_prio=0 tid=0x00007fc57821d800 nid=0x174d waiting on condition 
     [echo] 
     [echo] JNI global references: 2796
      [get] Getting: http://test-1-3/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/351112//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20191028161958256.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20191028161958256.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null287237750.properties

Failures in common with acceptance upstream results at f1f98ee:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
8 Tests Passed.
14 Tests Failed.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
Job Results:
2 Tests Passed.
6 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #278484

test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #328539

move-artifact:
[stopwatch] [run.batch.test.action: 37.311 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:368: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1765: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:2738: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/modules/build-app.xml:183: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/modules/build-app.xml:185: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/modules/build-app.xml:442: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/modules/build-app-module.xml:463: Warning: Could not find file /opt/dev/projects/github/liferay-portal/bundles/deploy/opensocial-portlet-7.2.0.1.war to copy.
      [get] Getting: http://test-1-4/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/328539//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20191028154701123.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20191028154701123.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1813579838.properties

...

brianchandotcom · 2019-10-28T20:43:07Z

Merged. Thank you.
View total diff: 438e9e1...23059e0

wincent and others added 2 commits October 28, 2019 11:06

LPS-102718 Dispose floating toolbar inside requestAnimationFrame

7a9acf0

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending labels Oct 28, 2019

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Oct 28, 2019

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 28, 2019

brianchandotcom closed this Oct 28, 2019

sandrodw3 deleted the pr-147 branch March 10, 2020 18:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-102718 Dispose floating toolbar inside requestAnimationFrame #80083

LPS-102718 Dispose floating toolbar inside requestAnimationFrame #80083

sandrodw3 commented Oct 28, 2019

liferay-continuous-integration commented Oct 28, 2019

sandrodw3 commented Oct 28, 2019

liferay-continuous-integration commented Oct 28, 2019

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 28, 2019

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8

Job Results:

brianchandotcom commented Oct 28, 2019

LPS-102718 Dispose floating toolbar inside requestAnimationFrame #80083

LPS-102718 Dispose floating toolbar inside requestAnimationFrame #80083

Conversation

sandrodw3 commented Oct 28, 2019

liferay-continuous-integration commented Oct 28, 2019

sandrodw3 commented Oct 28, 2019

liferay-continuous-integration commented Oct 28, 2019

✔️ ci:test:ci:test:sf - 1 out of 1 jobs passed in 2 minutes 42 seconds 531 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 28, 2019

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 18 out of 25 jobs passed in 1 hour 23 minutes 32 seconds 920 ms

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8

Job Results:

brianchandotcom commented Oct 28, 2019