[TS] LPS-90191, LPS-102185 #80873

ChrisKian · 2019-11-12T16:42:54Z

https://issues.liferay.com/browse/LPS-90191
https://issues.liferay.com/browse/LPS-102185

In response to your comments here: #79585 (comment), I had the following observations here: #80691 (comment)

Addressing your comment regarding naming conventions, I believe isn't actually needed. For the first file mentioned, "PortalSettingsTokenConstants", we can see some examples [1] [2] of the same naming convention. This is also true for the second file "TokenPortalSettingsFormContributor" [1] [2].

If you would like me to apply the changes anyways, please let me know. Thanks!

CC @achaparro, @drewbrokke, @stian-sigvartsen

…value properties

…d Instance Settings

…_VALUE for multi value fields

…before LPS-102185

liferay-continuous-integration · 2019-11-12T16:43:01Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2019-11-12T16:51:03Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes 24 seconds 572 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0bce4f065a4b3a4940f9d27ed3609e908998350f

Sender Branch:

Branch Name: pr-157
Branch GIT ID: 6a6da97c544e966611ed72cecc5036bc225dedb7

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2019-11-12T18:43:17Z

❌ ci:test:stable - 7 out of 8 jobs passed

❌ ci:test:relevant - 100 out of 114 jobs passed in 1 hour 46 minutes 59 seconds 435 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9606852942df9290f4d49e0066e3026008ec8eb2

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 4503009c0263f79e139e74ad06ca640aa2dcdf90

ci:test:stable - 7 out of 8 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/unit-jdk8~~

7 Successful Jobs:

ci:test:relevant - 100 out of 114 jobs PASSED

14 Failed Jobs:

100 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/37

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #296795

     [exec] * What went wrong:
     [exec] Execution failed for task ':runPoshi'.
     [exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html
     [exec] 
     [exec] * Try:
     [exec] 
     [exec] > Task :runPoshi FAILED
     [exec] 3 actionable tasks: 2 executed, 1 up-to-date
     [exec] Gradle build finished at 2019-11-12 17:50:59.922.
     [exec] 
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/portal-web/build/reports/profile/profile-2019-11-12-17-50-25.html
     [exec] A fine-grained performance profile is available: use the --scan option.
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':runPoshi'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
     [exec] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
     [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
     [exec] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
     [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/38

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #336199

     [exec] | | | | | | | | | | | | | | | |____index.html
     [exec] | | | | | | | | | | | | | | | |____summary.html
     [exec] Executing gzip.
     [exec] Listing files that were compressed.
     [exec] | | | | | | |____logs
     [exec] | | | | | | | |____test-1-23
     [exec] | | | | | | | | |____1573577471233
     [exec] | | | | | | | | | |____test-portal-acceptance-pullrequest(master)
     [exec] | | | | | | | | | | |____4915
     [exec] | | | | | | | | | | | |____functional-tomcat90-mysql57-jdk8
     [exec] | | | | | | | | | | | | |____38
     [exec] | | | | | | | | | | | | | |____0
     [exec] | | | | | | | | | | | | | | |____jenkins-console.txt.gz
     [exec] | | | | | | | | | | | | | | |____LocalFile.Test_Test
     [exec] | | | | | | | | | | | | | | | |____summary.html.gz
     [exec] | | | | | | | | | | | | | | | |____index.html.gz
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20191112173853432
     [echo] Warning: Unable to locate '/opt/dev/projects/github/liferay-jenkins-ee/testray/dependencies/test.generated.properties'.
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20191112173853635
BUILD FAILED

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:11264: The following error occurred while executing this line:

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common-portal-acceptance-batch.xml:218: The following error occurred while executing this line:

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:8548: Sourced file: inline evaluation of: 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : Typed variable declaration : Method Invocation GitHubDevSyncUtil.fetchCacheBranchFromGitHubDev : at Line: 47 : in file: inline evaluation of: 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : GitHubDevSyncUtil .fetchCacheBranchFromGitHubDev ( gitWorkingDirectory , remoteCacheBranchName )
Called from method: fetchCacheBranchToLocalBranch : at Line: 34 : in file: inline evaluation of: `` 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : fetchCacheBranchToLocalBranch ( sb .toString ( ) , gitWorkingDirectory .getUpstreamBranchName ( ) )

Target exception: java.lang.RuntimeException: Unable to fetch cache-liferay-9606852942df9290f4d49e0066e3026008ec8eb2-liferay-9606852942df9290f4d49e0066e3026008ec8eb2 from cloud-10-0-0-15

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/44
Job Results:
25 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #337158
  1. LocalFile.PGStaging#AddDMDocumentWCArticleStagingLocalLive - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/64

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #349872

     [exec] * What went wrong:

[exec] Execution failed for task ':runPoshi'.

[exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html

[exec]

[exec] * Try:

[exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.

[exec]

[exec] * Exception is:

[exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':runPoshi'.

[exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)

[exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)

[exec] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)

[exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)

[exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)

[exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)

[exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)

[exec] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)

[exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)

[exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)

[exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)

[exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

[exec] 	at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)

[exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)

[exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.run(EventFiringTaskExecuter.java:51)

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/81

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #336202

     [exec] | | | | | | | | | | | | | | | |____index.html

[exec] | | | | | | | | | | | | | | | |____summary.html

[exec] Executing gzip.

[exec] Listing files that were compressed.

[exec] | | | | | | |____logs

[exec] | | | | | | | |____test-1-23

[exec] | | | | | | | | |____1573577471233

[exec] | | | | | | | | | |____test-portal-acceptance-pullrequest(master)

[exec] | | | | | | | | | | |____4915

[exec] | | | | | | | | | | | |____functional-tomcat90-mysql57-jdk8

[exec] | | | | | | | | | | | | |____81

[exec] | | | | | | | | | | | | | |____0

[exec] | | | | | | | | | | | | | | |____jenkins-console.txt.gz

[exec] | | | | | | | | | | | | | | |____LocalFile.Test_Test

[exec] | | | | | | | | | | | | | | | |____summary.html.gz

[exec] | | | | | | | | | | | | | | | |____index.html.gz

[delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20191112174314756

[echo] Warning: Unable to locate '/opt/dev/projects/github/liferay-jenkins-ee/testray/dependencies/test.generated.properties'.

[delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20191112174314993
BUILD FAILED

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:11264: The following error occurred while executing this line:

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common-portal-acceptance-batch.xml:218: The following error occurred while executing this line:

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:8548: Sourced file: inline evaluation of: 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : Typed variable declaration : Method Invocation GitHubDevSyncUtil.fetchCacheBranchFromGitHubDev : at Line: 47 : in file: inline evaluation of: 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : GitHubDevSyncUtil .fetchCacheBranchFromGitHubDev ( gitWorkingDirectory , remoteCacheBranchName )
Called from method: fetchCacheBranchToLocalBranch : at Line: 34 : in file: inline evaluation of: `` 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : fetchCacheBranchToLocalBranch ( sb .toString ( ) , gitWorkingDirectory .getUpstreamBranchName ( ) )

Target exception: java.lang.RuntimeException: Unable to fetch cache-liferay-9606852942df9290f4d49e0066e3026008ec8eb2-liferay-9606852942df9290f4d49e0066e3026008ec8eb2 from cloud-10-0-0-16

brianchandotcom · 2019-11-13T00:09:31Z

Merged. Thank you.
View total diff: e498501...81b24c1

brianchandotcom · 2019-11-13T00:09:33Z

@ChrisKian got it.. it was consistent at one point and then we moved the packages around and never got to renaming the files...

In any case, your new stuff is still consistently inconsistent - which makes it consistent and good enough.

Thx!

stian-sigvartsen and others added 19 commits November 11, 2019 19:23

LPS-102185 SavePortalSettingsFormMVCActionCommand must support multi-…

a17f18c

…value properties

LPS-102185 Move configuration and constants to API module

c51e97b

LPS-102185 Move language keys to API module + new error key

10c8b1c

LPS-102185 New web module required for consistency with other SSOs an…

cca66b8

…d Instance Settings

LPS-102185 buildLang

471461d

LPS-102185 Auto SF

f71f142

LPS-102185 SF No need for immediate

1dc1d0a

LPS-102185 SF Simplify

d609bfd

LPS-102185 SF sort

d8156f0

LPS-102185 We can simplify a lot if we don't support TEMP_OBFUSCATION…

8597bf6

…_VALUE for multi value fields

LPS-102185 Auto SF

ead9a29

LPS-102185 Upgrade process

67ee5bf

LRQA-52676 LPS-102185 Pass in user token & portal url

b18df7c

LRQA-52676 LPS-102185 Assert Token-based SSO works with instance

5109d9d

LPS-102185 Hugo SF, type: git grep -B 5 -A 3 "registry.register" **.java

406d7e2

LPS-102185 auto SF

cb51124

LPS-90191 Change verifyProcesses into an upgrade process, and use it …

94d92fa

…before LPS-102185

LPS-90191 No longer needed

b8b30dc

LPS-102185 Hugo SF, type: git grep -B 5 -A 3 registry.register **.java

6a6da97

ChrisKian mentioned this pull request Nov 12, 2019

LPS-102185 ChrisKian/liferay-portal#157

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Nov 12, 2019

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Nov 12, 2019

liferay-continuous-integration added the ci:test:stable - failure label Nov 12, 2019

brianchandotcom closed this Nov 13, 2019

stian-sigvartsen mentioned this pull request Feb 19, 2020

LPS-102185 stian-sigvartsen/liferay-portal#201

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS] LPS-90191, LPS-102185 #80873

[TS] LPS-90191, LPS-102185 #80873

ChrisKian commented Nov 12, 2019 •

edited

liferay-continuous-integration commented Nov 12, 2019

liferay-continuous-integration commented Nov 12, 2019

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Nov 12, 2019

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

14 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/37

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/38

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/44

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/64

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/81

Job Results:

brianchandotcom commented Nov 13, 2019

brianchandotcom commented Nov 13, 2019

[TS] LPS-90191, LPS-102185 #80873

[TS] LPS-90191, LPS-102185 #80873

Conversation

ChrisKian commented Nov 12, 2019 • edited

liferay-continuous-integration commented Nov 12, 2019

liferay-continuous-integration commented Nov 12, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes 24 seconds 572 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Nov 12, 2019

❌ ci:test:stable - 7 out of 8 jobs passed

❌ ci:test:relevant - 100 out of 114 jobs passed in 1 hour 46 minutes 59 seconds 435 ms

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

14 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/37

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/38

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/44

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/64

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/81

Job Results:

brianchandotcom commented Nov 13, 2019

brianchandotcom commented Nov 13, 2019

ChrisKian commented Nov 12, 2019 •

edited