Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-104573 SF #80953

Closed
wants to merge 5 commits into from
Closed

LPS-104573 SF #80953

wants to merge 5 commits into from

Conversation

epgarcia
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 18 seconds 619 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d878e4b9574f7513353f7a4b444361a976538b54

Sender Branch:

Branch Name: pr-987
Branch GIT ID: cbd6c4fdcbb3cf44b8c4e46b591210dfae05a338

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: c95a2e8...de28695

@brianchandotcom
Copy link
Owner

@epgarcia see de28695 for my comments. I'm not sure which one is more accurate

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 8 out of 8 jobs passed

❌ ci:test:relevant - 19 out of 21 jobs passed in 1 hour 17 minutes 42 seconds 892 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 75ef5c682a28289697ec013e4580dd2a1a017808

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: e3c77d796a13012cae61bb5f6fec842d349143ac

ci:test:stable - 8 out of 8 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 19 out of 21 jobs PASSED
19 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #312415
           [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:5279: 2 PMD violation(s) were found.
     [echo] 
     [echo] PMD VIOLATION: /opt/dev/projects/github/liferay-portal/portal-impl/src/com/liferay/portal/service/impl/RoleLocalServiceImpl.java:307 > Avoid unused local variables such as 'key'. (PMD Rule: UnusedLocalVariable)
     [echo] For more information, please see https://pmd.github.io/pmd-6.8.0/pmd_rules_java_bestpractices.html#unusedlocalvariable.
     [echo] 
     [echo] PMD VIOLATION: /opt/dev/projects/github/liferay-portal/portal-impl/src/com/liferay/portal/service/impl/RoleLocalServiceImpl.java:333 > Avoid unused local variables such as 'key'. (PMD Rule: UnusedLocalVariable)
     [echo] For more information, please see https://pmd.github.io/pmd-6.8.0/pmd_rules_java_bestpractices.html#unusedlocalvariable.
[beanshell] 
[beanshell] ##
[beanshell] ## git.plugins.properties
[beanshell] ##
[beanshell] 
[beanshell] github.upstream.branch.name=7.0.x
[beanshell] github.sender.branch.sha=f91d1b197ff0cb01ba2757acbf9e8321fc16466f
[beanshell] github.receiver.username=liferay
[beanshell] github.sender.branch.name=7.0.x
[beanshell] github.pull.request.number=0
[beanshell] github.upstream.branch.sha=f91d1b197ff0cb01ba2757acbf9e8321fc16466f
[beanshell] github.sender.username=liferay
[beanshell] local.git.branch.cached=true
[beanshell] github.origin.name=liferay
[beanshell] 
[beanshell] 
[beanshell] ##
[beanshell] ## git.portal.properties
[beanshell] ##
[beanshell] 
[beanshell] github.upstream.branch.name=master
[beanshell] github.sender.branch.sha=cbd6c4fdcbb3cf44b8c4e46b591210dfae05a338
[beanshell] github.receiver.username=brianchandotcom
[beanshell] github.sender.branch.name=pr-987
[beanshell] github.pull.request.number=80953
[beanshell] github.upstream.branch.sha=75ef5c682a28289697ec013e4580dd2a1a017808
[beanshell] github.sender.username=epgarcia
[beanshell] local.git.branch.cached=true
[beanshell] github.origin.name=epgarcia
[beanshell] 
     [echo] WARNING: pmd-jdk8 does not match existing test types (blade-samples,database-upgrade-client,functional,jsf,plugins,portal-startup,service-builder,tck,modules-integration,integration,modules-unit,modules-unit-project-templates,unit)
     [echo] WARNING: pmd-jdk8 does not match existing test types (blade-samples,database-upgrade-client,functional,jsf,plugins,portal-startup,service-builder,tck,modules-integration,integration,modules-unit,modules-unit-project-templates,unit)

For upstream results, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
4 participants
@epgarcia @liferay-continuous-integration @brianchandotcom @dgarciasarai