Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-105188 Remove singleSelect to prevent that the default selection close the itemSelector #81629

Conversation

boton
Copy link

@boton boton commented Dec 4, 2019

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@boton
Copy link
Author

boton commented Dec 4, 2019

/cc @pavel-savinov @ambrinchaudhary

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 16 seconds 207 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7d34f6c74b1ba3d09865b748d7b7edc11a011e9d

Sender Branch:

Branch Name: LPS-105188-item-selector-navigation-menu-autoclose
Branch GIT ID: 799056d803c84575abd55f3ea119fe6448591f18

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 8 out of 8 jobs passed

❌ ci:test:relevant - 21 out of 24 jobs passed in 1 hour 21 minutes 14 seconds 553 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7d34f6c74b1ba3d09865b748d7b7edc11a011e9d

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: c2ee0d3906691d67d2f2d033fc852b2f407a2a9c

ci:test:stable - 8 out of 8 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 21 out of 24 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 7d34f6c:
  1. test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8
    Job Results:

    734 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #302241
      1. reducers.layoutDataReducer REMOVE_ITEM removes an item from layoutData.items
        Error: expect(received).toEqual(expected)
        

        Difference:

        • Expected
        • Received

        @@ -1,8 +1,17 @@
        Object {

        • "example-fragment-0": Object {
        • "children": Array [],
          
        • "config": Object {},
          
        • "itemId": "example-fragment-0",
          
        • "parentId": "root-item-0",
          
        • "type": "fragment",
          
        • },
          "root-item-0": Object {
        • "children": Array [],
          
        • "children": Array [
          
        •   "example-fragment-0",
          
        • ],
          "config": Object {},
          "itemId": "root-item-0",
          "parentId": null,
          "type": "root",
          
          },
          at Object.toEqual (layout/layout-content-page-editor-web/test/page_editor/app/reducers/layoutDataReducer.test.js:156:39)
          at Object.asyncJestTest (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
          at resolve (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
          at new Promise (<anonymous>)
          at mapper (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
          at promise.then (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
          at process._tickCallback (internal/process/next_tick.js:68:7)
  2. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #208124

      Please fix semantic versioning on boton/LPS-105188-item-selector-navigation-menu-autoclose

           [exec]
      [exec] > Task :apps:site-navigation:site-navigation-language-web:autoUpdateXml SKIPPED
      [exec] > Task :apps:site-navigation:site-navigation-language-web:baseline SKIPPED
      [exec] > Task :apps:site-navigation:site-navigation-language-web:syncVersions
      [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/site-navigation/site-navigation-menu-item-layout/build/jspc/org/apache/jsp/edit_005flayout_jsp.java uses or overrides a deprecated API.
      [exec] Note: Recompile with -Xlint:deprecation for details.
      [exec]
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-layout:compileJSP
      [exec]
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-layout:jar
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-layout:autoUpdateXml SKIPPED
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-layout:baseline SKIPPED
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-layout:syncVersions
      [exec]
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-url:generateJSPJava
      [exec] Compiling JSP files of project ':apps:site-navigation:site-navigation-menu-item-url' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.17/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
      [exec]
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-url:compileJSP
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-url:jar
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-url:autoUpdateXml SKIPPED
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-url:baseline SKIPPED
      [exec] > Task :apps:site-navigation:site-navigation-menu-item-url:syncVersions
      [exec] Gradle build finished at 2019-12-04 15:00:43.024.
      [exec]
      [exec]
      [exec] FAILURE: Build failed with an exception.
      [exec]
      [exec] * What went wrong:
      [exec] Execution failed for task ':apps:site:site-item-selector-api:baseline'.
      [exec] > Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.site.item.selector.api-4.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.site.item.selector.api/3.0.1/d2374db55855f486d3dd07bb858c63c3b9372404/com.liferay.site.item.selector.api-3.0.1.jar

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 1c022b0...d93764f

@boton boton deleted the LPS-105188-item-selector-navigation-menu-autoclose branch January 14, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants