Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-105946 Using a more specific name #82120

Closed
wants to merge 5 commits into from
Closed

LPS-105946 Using a more specific name #82120

wants to merge 5 commits into from

Conversation

4lejandrito
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@4lejandrito
Copy link
Author

Hi @brianchandotcom,

I did create the updateSearchable method however for the moment we will not create the remote service. We will do so once we tackle the permissions epic.

Thanks!

@4lejandrito 4lejandrito mentioned this pull request Dec 17, 2019
Closed
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 34 seconds 25 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cb34aedc8a1b7fc01bada03ccf023a13e2712ac6

Sender Branch:

Branch Name: LPS-105946
Branch GIT ID: 49d07329f2c608697b46729fdd67aac5028df47c

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 8 out of 8 jobs passed

✔️ ci:test:relevant - 22 out of 22 jobs passed in 1 hour 53 minutes 8 seconds 943 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cb34aedc8a1b7fc01bada03ccf023a13e2712ac6

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6c0b5322d1e18eac4342d74f6522c7b7a9bbd7ed

ci:test:stable - 8 out of 8 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 22 out of 22 jobs PASSED
22 Successful Jobs:
For more details click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: a2ff5b8...3668f7e

@brianchandotcom
Copy link
Owner

@4lejandrito you still need a remote service with permission checking

UpdateSearchableMVCActionCommand.java calls

_depotEntryGroupRelLocalService.updateSearchable(

That means as long as I have access to the portlet, and know your ID, I can update searchable.

So *Command calls *ServiceImpl (with permission check) calls *LocalServiceImpl

Please fix. @adolfopa fyi.

Merged.. but need a follow up pull. This is a security risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@4lejandrito @liferay-continuous-integration @brianchandotcom