[DO-NOT-MERGE] LPS-105228 Move converter to vulcan to allow extensability and start using it in Organization #82465

javiergamarra · 2019-12-25T10:46:56Z

Just to discuss converter in Vulcan.

The idea is to have a central registry of entities to reuse conversion and allow extensibility for end users (to add or remove properties in existing Liferay APIs)

-- Resent fixing circular dependency
-- Resent fixing a test fixed in previous PR

…s (that can allow for extension)

liferay-continuous-integration · 2019-12-25T10:47:02Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2019-12-25T10:49:56Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 39 seconds 344 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 35fdd05de1886c8b08458c95365e3f4c61039955

Sender Branch:

Branch Name: LPS-105228_new_pattern
Branch GIT ID: b481028dc174e499e9786ba6df221fbae93588db

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2019-12-25T12:05:05Z

❌ ci:test:stable - 7 out of 8 jobs passed

❌ ci:test:relevant - 16 out of 19 jobs passed in 1 hour 17 minutes 29 seconds 914 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0951fd4ddf92d0237715e5e4f5556e2ba5db3f60

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: f974066a1816a014c2c71d1641a953466a70ec53

ci:test:stable - 7 out of 8 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8~~

7 Successful Jobs:

ci:test:relevant - 16 out of 19 jobs PASSED

3 Failed Jobs:

16 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

4 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #241216

     [echo] 
     [echo] Called from method: fetchCacheBranchToLocalBranch : at Line: 34 : in file: inline evaluation of: `` 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : fetchCacheBranchToLocalBranch ( sb .toString ( ) , gitWorkingDirectory .getUpstreamBranchName ( ) ) 
     [echo] Target exception: java.lang.RuntimeException: Unable to fetch cache-liferay-0951fd4ddf92d0237715e5e4f5556e2ba5db3f60-liferay-0951fd4ddf92d0237715e5e4f5556e2ba5db3f60 from cloud-10-0-0-32
     [echo] record.testray.results.start.timestamp: 12-25-2019 03:41:20:711 PST
[stopwatch] [record.testray.results: 0.001 sec]
BUILD FAILED

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:11378: The following error occurred while executing this line:

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common-portal-acceptance-batch.xml:234: The following error occurred while executing this line:

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:8714: Sourced file: inline evaluation of: 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : Typed variable declaration : Method Invocation GitHubDevSyncUtil.fetchCacheBranchFromGitHubDev : at Line: 47 : in file: inline evaluation of: 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : GitHubDevSyncUtil .fetchCacheBranchFromGitHubDev ( gitWorkingDirectory , remoteCacheBranchName )
Called from method: fetchCacheBranchToLocalBranch : at Line: 34 : in file: inline evaluation of: `` 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : fetchCacheBranchToLocalBranch ( sb .toString ( ) , gitWorkingDirectory .getUpstreamBranchName ( ) )

Target exception: java.lang.RuntimeException: Unable to fetch cache-liferay-0951fd4ddf92d0237715e5e4f5556e2ba5db3f60-liferay-0951fd4ddf92d0237715e5e4f5556e2ba5db3f60 from cloud-10-0-0-32

Failures in common with acceptance upstream results at 0951fd4:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

201 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #214447

ProjectTemplatesTest.testCompareGradlePluginVersions

org.junit.ComparisonFailure: com.liferay.plugin versions do not match expected:<4.4.10[5]> but was:<4.4.10[8]>

at org.junit.Assert.assertEquals(Assert.java:115)

at com.liferay.project.templates.ProjectTemplatesTest.testCompareGradlePluginVersions(ProjectTemplatesTest.java:2949)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)

at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)

at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)

at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)

at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)

at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)

at org.junit.rules.RunRules.evaluate(RunRules.java:20)

at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)

at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)

at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)

at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)

at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)

at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)

at org...

javiergamarra · 2019-12-26T08:35:54Z

ci:test:relevant

liferay-continuous-integration · 2019-12-26T10:03:05Z

✔️ ci:test:stable - 8 out of 8 jobs passed

❌ ci:test:relevant - 17 out of 19 jobs passed in 1 hour 26 minutes 30 seconds 616 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: df3fe0e6bca1341a8d1333f9f8d423a512fa49d3

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 795780cfb463ce0f37817086ef3edcb02790c91c

ci:test:stable - 8 out of 8 jobs PASSED

8 Successful Jobs:

ci:test:relevant - 17 out of 19 jobs PASSED

2 Failed Jobs:

17 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at df3fe0e:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

201 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #348264

ProjectTemplatesTest.testCompareGradlePluginVersions

org.junit.ComparisonFailure: com.liferay.plugin versions do not match expected:<4.4.10[5]> but was:<4.4.10[8]>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at com.liferay.project.templates.ProjectTemplatesTest.testCompareGradlePluginVersions(ProjectTemplatesTest.java:2949)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org...

brianchandotcom · 2020-01-02T22:27:10Z

@nhpatt please resend on top of my changes to #82686 since it touches DTO too.

Vulcan changes first (then backport) then String. Thx.

javiergamarra added 10 commits December 25, 2019 11:45

LPS-105228 move DTO converter context to Vulcan

b3b4e9d

LPS-105228 add a new registry to be potentially used with all the DTO…

88b0e91

…s (that can allow for extension)

LPS-105228 adapt existing DTOs

5b22940

LPS-105228 change organization id to support external reference code

16b710f

LPS-105228 create new converter for Organisation

67fc0a7

LPS-105228 adapt related resources to use new converter

2dfecee

LPS-105228 fix type error with GraphQL tests

b6af8fc

LPS-105228 generate

f896e26

LPS-105228 remove registry to avoid circular dependency

0a9ae54

LPS-105228 regenerate

b481028

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Dec 25, 2019

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels Dec 25, 2019

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure and removed ci:test:relevant - failure ci:test:stable - failure ci:test:relevant - pending ci:test:stable - pending labels Dec 26, 2019

liferay-continuous-integration added the ci:test:stable - success label Dec 26, 2019

brianchandotcom closed this Jan 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO-NOT-MERGE] LPS-105228 Move converter to vulcan to allow extensability and start using it in Organization #82465

[DO-NOT-MERGE] LPS-105228 Move converter to vulcan to allow extensability and start using it in Organization #82465

javiergamarra commented Dec 25, 2019

liferay-continuous-integration commented Dec 25, 2019

liferay-continuous-integration commented Dec 25, 2019

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 25, 2019

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

javiergamarra commented Dec 26, 2019

liferay-continuous-integration commented Dec 26, 2019

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

brianchandotcom commented Jan 2, 2020

[DO-NOT-MERGE] LPS-105228 Move converter to vulcan to allow extensability and start using it in Organization #82465

[DO-NOT-MERGE] LPS-105228 Move converter to vulcan to allow extensability and start using it in Organization #82465

Conversation

javiergamarra commented Dec 25, 2019

liferay-continuous-integration commented Dec 25, 2019

liferay-continuous-integration commented Dec 25, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 39 seconds 344 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 25, 2019

❌ ci:test:stable - 7 out of 8 jobs passed

❌ ci:test:relevant - 16 out of 19 jobs passed in 1 hour 17 minutes 29 seconds 914 ms

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

javiergamarra commented Dec 26, 2019

liferay-continuous-integration commented Dec 26, 2019

✔️ ci:test:stable - 8 out of 8 jobs passed

❌ ci:test:relevant - 17 out of 19 jobs passed in 1 hour 26 minutes 30 seconds 616 ms

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

brianchandotcom commented Jan 2, 2020