LPS-107202 Update liferay-npm-scripts to v19.0.2 #83439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains nothing not already present in the canonical config file higher up in the repo, and it is going to cause trouble in the next commit anyway (because it adds a lint forcing the use of ".prettierrc.js" instead of ".prettierrc"), so let's just delete it.
The new version switches our Babel default config over to assume React, enabling us to eliminate a bunch of duplicative config. The new version of liferay-npm-scripts also includes lints to make sure that: - The default presets are not redundantly specified in config files. - Config files use JS-based formats that we can easily lint (eg. ".babelrc.js", ".eslintrc.js" etc) instead of others (eg. ".eslintrc" etc). There are two projects where we have to suppress the React preset because their use of incremental-dom is incompatible. Those are dynamic-data-mapping-form-web and dynamic-data-mapping-form-builder. Once we migrate those projects off of incremental-dom, we can remove those config files entirely. Note that both of these have been ported from ".babelrc" (JSON) to ".babelrc.js" so that the aforementioned lints can apply; as such, we get formatting for free too.
Addresses JS test failure mentioned here: brianchandotcom#83438 (comment) Actual fix was: liferay/liferay-npm-tools#343
|
CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests. Comment "ci:test" to run the full PR Tester for this pull. |
|
In my local testing, I am seeing a JS test failure in That one is already being tracked in LPS-107247. |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 44 seconds 128 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: wincent/LPS-107202/liferay-npm-scripts-v19 1 Successful Jobs:For more details click here. |
brianchandotcom
force-pushed
the
master
branch
from
726fc07
to
ad09799
Compare
|
Merged. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #83438 (fixes tests).
TL;DR
From commit 36cf902:
Originally tested here: wincent#120