LPS-107456 Create account rest modules #83667

drewbrokke · 2020-01-22T20:01:20Z

This is an update for LPS-107456.

Hey Brian, this pull only creates the new Account Rest modules. I'm sending you this first so we can verify naming before I build out the schema components and endpoints.

/cc @pei-jung @alee8888 @ChrisKian @dejuknow @patriciajeanperez

liferay-continuous-integration · 2020-01-22T20:01:29Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2020-01-22T20:04:35Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 43 seconds 675 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 703bb0fc111b89e8d3bd614a8a06ad233cc8a6a6

Sender Branch:

Branch Name: LPS-107456-create-rest-module
Branch GIT ID: ca7a5d570c0bea80b04489dfb997f7b29e0ce342

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-01-22T21:33:58Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 17 out of 21 jobs passed in 1 hour 31 minutes 47 seconds 120 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2282a4e8ea0bd40cc0dc189bd6f944652f6a58c9

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 675fd6f1716b42f77cc332cad8893e473d800091

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 17 out of 21 jobs PASSED

4 Failed Jobs:

17 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8

Job Results:

1362 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #330656

single-reassign.The SingleReassignModal component should Render alert with success message and close modal

TypeError: Cannot convert undefined or null to object
    at Function.assign (<anonymous>)
    at Object.createEvent.(anonymous function) [as click] (/opt/dev/projects/github/liferay-portal/modules/node_modules/@testing-library/dom/dist/events.js:643:12)
    at Function.fireEvent.(anonymous function) [as click] (/opt/dev/projects/github/liferay-portal/modules/node_modules/@testing-library/dom/dist/events.js:649:68)
    at /opt/dev/projects/github/liferay-portal/modules/node_modules/@testing-library/react/dist/index.js:148:40
    at batchedUpdates$1 (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:21643:12)
    at act (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1002:14)
    at act (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1418:12)
    at Function.fireEvent.(anonymous function).args [as click] (/opt/dev/projects/github/liferay-portal/modules/node_modules/@testing-library/react/dist/index.js:147:28)
    at Object.click (/opt/dev/projects/github/liferay-portal/modules/dxp/apps/portal-workflow/portal-workflow-metrics-web/test/components/instance-list-page/modal/single-reassign/SingleReassignModal.es.js:149:13)
    at Object.asyncJestTest (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/opt/dev/projects/github/li...

bulk-reassign.The BulkReassignModal component should Render "Select assignees" step with reassignee fetch error and retrying

TypeError: Cannot convert undefined or null to object
    at Function.assign (<anonymous>)
    at Object.createEvent.(anonymous function) [as click] (/opt/dev/projects/github/liferay-portal/modules/node_modules/@testing-library/dom/dist/events.js:643:12)
    at Function.fireEvent.(anonymous function) [as click] (/opt/dev/projects/github/liferay-portal/modules/node_modules/@testing-library/dom/dist/events.js:649:68)
    at /opt/dev/projects/github/liferay-portal/modules/node_modules/@testing-library/react/dist/index.js:148:40
    at batchedUpdates$1 (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom.development.js:21643:12)
    at act (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1002:14)
    at act (/opt/dev/projects/github/liferay-portal/modules/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1418:12)
    at Function.fireEvent.(anonymous function).args [as click] (/opt/dev/projects/github/liferay-portal/modules/node_modules/@testing-library/react/dist/index.js:147:28)
    at Object.click (/opt/dev/projects/github/liferay-portal/modules/dxp/apps/portal-workflow/portal-workflow-metrics-web/test/components/instance-list-page/modal/bulk-reassign/BulkReassignModal.es.js:361:13)
    at process._tickCallback (internal/process/next_tick.js:68:7)

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #290105

Startup error: Unresolved Requirement(s)

     [exec] 	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
     [exec] 	at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
     [exec] 21:03:11,675 ERROR [Framework Event Dispatcher: Equinox Container: 0b80f327-66c1-4158-969e-af62247b4441][Framework:108] Exiting the JVM 
     [exec] org.osgi.framework.BundleException: Could not resolve module: com.liferay.data.engine.rest.api [107]
     [exec]   Unresolved requirement: Import-Package: com.liferay.portal.vulcan.accept.language; version="[1.0.0,2.0.0)"
     [exec]     -> Export-Package: com.liferay.portal.vulcan.accept.language; bundle-symbolic-name="com.liferay.portal.vulcan.api"; bundle-version="4.2.1"; version="1.0.0"
     [exec]        com.liferay.portal.vulcan.api [719]
     [exec]          Unresolved requirement: Import-Package: com.liferay.oauth2.provider.scope; version="[1.0.0,2.0.0)"; resolution:="optional"
     [exec]          Unresolved requirement: Import-Package: com.liferay.oauth2.provider.scope.liferay; version="[2.0.0,3.0.0)"
     [exec]   Unresolved requirement: Import-Package: com.liferay.portal.vulcan.graphql.annotation; version="[1.2.0,2.0.0)"
     [exec]     -> Export-Package: com.liferay.portal.vulcan.graphql.annotation; bundle-symbolic-name="com.liferay.portal.vulcan.api"; bundle-version="4.2.1"; version="1.2.0"
     [exec] 
     [exec] 	at org.eclipse.osgi.container.Module.start(Module.java:444)
     [exec] 	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
     [exec] 	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
     [exec] 	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
     [exec] 	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
     [exec] 	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
     [exec] 	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
     [exec] 	at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
     [exec] 21:03:11,686 DEBUG [Start Level: Equinox Container: 0b80f327-66c1-4158-969e-af62247b4441][BundleStartStopLogger:48] STARTED woodstox-core-asl_4.4.1 [114]

Failures in common with acceptance upstream results at 8760b71:

test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8

Job Results:

1362 Tests Passed.
3 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #330656

criteria_builder.CriteriaRow renders

Error: expect(value).toMatchSnapshot()
Received value does not match stored snapshot "CriteriaRow renders 1".

Snapshot


Received

@@ -32,11 +32,11 @@

data-testid="simple-string"

type="text"

value="test_val"

/>

<button


    class="btn-outline-borderless btn-sm btn btn-monospaced btn-secondary"





    class="btn-outline-borderless btn-sm mr-1 btn btn-monospaced btn-secondary"
    type="button"
  &gt;
    &lt;svg
      class="lexicon-icon lexicon-icon-paste"
      role="presentation"

at Object.toMatchSnapshot (segments/segments-web/test/js/components/criteria_builder/CriteriaRow.es.js:58:24)

at Object.asyncJestTest (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)

at resolve (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:43:12)

at new Promise (<anonymous>)

at mapper (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:26:19)

at promise.then (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:73:41)

at process._tickCallback (internal/process/next_tick.js:68:7)

criteria_builder.CriteriaRow renders and inform there is an unknown property
```
Error: expect(value).toMatchSnapshot()
```



Received value does not match stored snapshot "CriteriaRow renders and inform there is an unknown property 1".

Snapshot


Received

@@ -45,25 +45,45 @@

</div>

<div

class="bg-transparent border-0 mt-1 p-1 alert alert-danger"

role="alert"

>


&lt;span



  class="alert-indicator"





&lt;div



  class="alert-autofit-row autofit-row"
&gt;





  &lt;svg



    class="lexicon-icon lexicon-icon-exclamation-full"



    role="presentation"





  &lt;div



    class="autofit-col"
  &gt;





    &lt;use



      xlink:href="#exclamation-full"



    /&gt;



  &lt;/svg&gt;



&lt;/span&gt;



&lt;strong



  class="lead"



&gt;



  error



&lt;/strong&gt;



criteria-error-message-edit





    &lt;div



      class="autofit-section"



    &gt;



      &lt;span



        class="alert-indicator"



      &gt;



        &lt;svg



          class="lexicon-icon lexicon-icon-exclamation-full"



          role="presentation"



        &gt;



          &lt;use



            xlink:href="#exclamation-full"



          /&gt;



        &lt;/svg&gt;



      &lt;/span&gt;



    &lt;/div&gt;



  &lt;/div&gt;



  &lt;div



    class="autofit-col autofit-col-expand"



  &gt;



    &lt;div



      class="autofit-section"



    &gt;



      &lt;strong



        class="lead"



      &gt;



        error



      &lt;/strong&gt;



      criteria-error-message-edit



 ...</code></pre></div></li><li><div><a href="https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/330656//testReport/segments.segments-web.test.js.components/segment_edit/SegmentEdit_renders_with_given_values">segment_edit.SegmentEdit renders with given values</a><pre><code>Error: expect(value).toMatchSnapshot()



Received value does not match stored snapshot "SegmentEdit renders with given values 1".

Snapshot


Received

@@ -423,11 +423,11 @@

data-testid="simple-string"

type="text"

value="value"

/>

<button


                          class="btn-outline-borderless btn-sm btn btn-monospaced btn-secondary"

class="btn-outline-borderless btn-sm mr-1 btn btn-monospaced btn-secondary" type="button" > <svg class="lexicon-icon lexicon-icon-paste" role="presentation" at Object.toMatchSnapshot (segments/segments-web/test/js/components/segment_edit/SegmentEdit.es.js:157:24) at Object.asyncJestTest (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37) at resolve (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:43:12) at new Promise (<anonymous>) at mapper (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:26:19) at promise.then (/opt/dev/projects/github/liferay-portal/modules/node_modules/jest-jasmine2/build/queueRunner.js:73:41) ...

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

210 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #230886

ProjectTemplateFilesTest.testProjectTemplateFiles

org.junit.ComparisonFailure: Forbidden leading or trailing whitespaces in ../project-templates-npm-react-portlet/src/main/resources/archetype-resources/.babelrc.js expected:<... ["env", "react"]

};[]> but was:<... ["env", "react"]

};[

]>

at org.junit.Assert.assertEquals(Assert.java:115)

at com.liferay.project.templates.ProjectTemplateFilesTest._testTextFile(ProjectTemplateFilesTest.java:926)

at com.liferay.project.templates.ProjectTemplateFilesTest._testTextFile(ProjectTemplateFilesTest.java:951)

at com.liferay.project.templates.ProjectTemplateFilesTest.access$400(ProjectTemplateFilesTest.java:70)

at com.liferay.project.templates.ProjectTemplateFilesTest$1.visitFile(ProjectTemplateFilesTest.java:895)

at com.liferay.project.templates.ProjectTemplateFilesTest$1.visitFile(ProjectTemplateFilesTest.java:840)

at java.nio.file.Files.walkFileTree(Files.java:2670)

at java.nio.file.Files.walkFileTree(Files.java:2742)

at com.liferay.project.templates.ProjectTemplateFilesTest._testProjectTemplateFiles(ProjectTemplateFilesTest.java:838)

at com.liferay.project.templates.ProjectTemplateFilesTest.testProjectTemplateFiles(ProjectTemplateFilesTest.java:84)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)

at org.junit.runners.model.FrameworkMeth...

brianchandotcom · 2020-01-24T06:30:32Z

Merged. Thank you.
View total diff: 3fe7814...23b2676

brianchandotcom · 2020-01-24T06:30:39Z

@drewbrokke I added the releng ignore files

drewbrokke added 4 commits January 22, 2020 14:00

LPS-107456 account-rest-impl - adds new module

e22bf10

LPS-107456 account - buildrest

98a93f4

LPS-107456 account-rest-impl - adds dependencies (fixes compile errors)

e26ef02

LPS-107456 account-rest-client - adds module files

ca7a5d5

drewbrokke mentioned this pull request Jan 22, 2020

LPS-107456 Create account rest modules #83665

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Jan 22, 2020

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Jan 22, 2020

brianchandotcom closed this Jan 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-107456 Create account rest modules #83667

LPS-107456 Create account rest modules #83667

drewbrokke commented Jan 22, 2020

liferay-continuous-integration commented Jan 22, 2020

liferay-continuous-integration commented Jan 22, 2020

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 22, 2020

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

brianchandotcom commented Jan 24, 2020

brianchandotcom commented Jan 24, 2020

LPS-107456 Create account rest modules #83667

LPS-107456 Create account rest modules #83667

Conversation

drewbrokke commented Jan 22, 2020

liferay-continuous-integration commented Jan 22, 2020

liferay-continuous-integration commented Jan 22, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 43 seconds 675 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jan 22, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 17 out of 21 jobs passed in 1 hour 31 minutes 47 seconds 120 ms

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

brianchandotcom commented Jan 24, 2020

brianchandotcom commented Jan 24, 2020