Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-110094 Fix questions card height #86534

Closed
wants to merge 1 commit into from

Conversation

edalgrin
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes 149 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cdea63faec68c6b5b2c02b7cf3d7c4359364654a

Sender Branch:

Branch Name: LPS-110094-B
Branch GIT ID: cd07f1541dd7b3dbd21f71453f1cfae304705a82

0 out of 1jobs PASSED
For more details click here.
     [exec] Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
     [exec] Using proxy squid.lax.liferay.com:3128.
     [exec] Configuration on demand is an incubating feature.
     [exec] 
     [exec] > Task :yarnCheckFormat
     [exec] Running the Yarn "checkFormat" script
     [exec] 
     [exec] > Task :downloadNode SKIPPED
     [exec] 
     [exec] > Task :yarnCheckFormatModules
     [exec] yarn run v1.13.0
     [exec] \$ liferay-npm-scripts check --production false
     [exec] Prettier checked 2 files
     [exec] /opt/dev/projects/github/liferay-portal/modules/apps/questions/questions-web/src/main/resources/META-INF/resources/js/pages/home/Home.js
     [exec]   46:18  error  classes in className attribute must be sorted  liferay/sort-class-names
     [exec]   50:19  error  classes in className attribute must be sorted  liferay/sort-class-names
     [exec] 
     [exec] ??? 2 problems (2 errors, 0 warnings)
     [exec]   2 errors and 0 warnings potentially fixable with the `--fix` option.
     [exec] 
     [exec] 1 of 3 jobs failed
     [exec] error Command failed with exit code 1.
     [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
     [exec] 
     [exec] > Task :yarnCheckFormatModules FAILED
     [exec] Gradle build finished at 2020-03-19 10:56:37.321.
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':yarnCheckFormatModules'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':yarnCheckFormatModules'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter\$3.accept(ExecuteActionsTaskExecuter.java:166)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter\$3.accept(ExecuteActionsTaskExecuter.java:163)
     [exec] 	at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:191)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:156)

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 29 out of 29 jobs passed in 1 hour 44 minutes 25 seconds 171 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 60df34d7b26374e6578a9d57934feffe848bd308

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 3838dac2ae9689eceb6374dee03b44cf836abfdb

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 29 out of 29 jobs PASSED
29 Successful Jobs:
For more details click here.

@jpince
Copy link
Collaborator

jpince commented Mar 19, 2020

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes 42 seconds 437 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cdea63faec68c6b5b2c02b7cf3d7c4359364654a

Sender Branch:

Branch Name: LPS-110094-B
Branch GIT ID: cd07f1541dd7b3dbd21f71453f1cfae304705a82

0 out of 1jobs PASSED
For more details click here.
     [exec] Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
     [exec] Using proxy squid.lax.liferay.com:3128.
     [exec] Configuration on demand is an incubating feature.
     [exec] 
     [exec] > Task :yarnCheckFormat
     [exec] Running the Yarn "checkFormat" script
     [exec] 
     [exec] > Task :downloadNode SKIPPED
     [exec] 
     [exec] > Task :yarnCheckFormatModules
     [exec] yarn run v1.13.0
     [exec] \$ liferay-npm-scripts check --production false
     [exec] Prettier checked 2 files
     [exec] /opt/dev/projects/github/liferay-portal/modules/apps/questions/questions-web/src/main/resources/META-INF/resources/js/pages/home/Home.js
     [exec]   46:18  error  classes in className attribute must be sorted  liferay/sort-class-names
     [exec]   50:19  error  classes in className attribute must be sorted  liferay/sort-class-names
     [exec] 
     [exec] ??? 2 problems (2 errors, 0 warnings)
     [exec]   2 errors and 0 warnings potentially fixable with the `--fix` option.
     [exec] 
     [exec] 1 of 3 jobs failed
     [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
     [exec] error Command failed with exit code 1.
     [exec] 
     [exec] > Task :yarnCheckFormatModules FAILED
     [exec] Gradle build finished at 2020-03-19 15:17:12.580.
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':yarnCheckFormatModules'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':yarnCheckFormatModules'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter\$3.accept(ExecuteActionsTaskExecuter.java:166)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter\$3.accept(ExecuteActionsTaskExecuter.java:163)
     [exec] 	at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:191)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:156)

@jpince
Copy link
Collaborator

jpince commented Mar 19, 2020

ci:close @eduardoallegrini please fix SF errors

     [exec] /opt/dev/projects/github/liferay-portal/modules/apps/questions/questions-web/src/main/resources/META-INF/resources/js/pages/home/Home.js
     [exec]   46:18  error  classes in className attribute must be sorted  liferay/sort-class-names
     [exec]   50:19  error  classes in className attribute must be sorted  liferay/sort-class-names

@edalgrin
Copy link
Author

edalgrin commented Mar 19, 2020

Thanks @jpince, #86558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants