LPS-97802 As used #87650
Closed
LPS-97802 As used #87650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DMFormInstanceRecordUADDisplay
… classes with static methods. I just made the methods static.
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
|
@gabrielibson @natocesarrego nice job guys! see my tiny changes in my origin. |
Closed
|
Understood, @brianchandotcom. Thanks a lot for your review! This was a tough one, but we'll use this pull as a template in order to deliver better pulls in the future. And we keep learning from you. 🙂 Obrigado! |
liferay-continuous-integration
deleted the
ci-forward-pr-457-pr-461-sender-natocesarrego-ts-1586984956647
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: natocesarrego#461
@natocesarrego
✔️ ci:test:stable - 17 out of 17 jobs passed
✔️ ci:test:relevant - 34 out of 34 jobs passed in 1 hour 58 minutes 455 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 7e7782a8cfb106ddfb68231dc8f217633b4a8110
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: dedb2cf07c7105cbb78b2a4f981022f7a7a84946
ci:test:stable - 17 out of 17 jobs PASSED
17 Successful Jobs:
ci:test:relevant - 34 out of 34 jobs PASSED
34 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes 25 seconds 46 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 7e7782a8cfb106ddfb68231dc8f217633b4a8110
Sender Branch:
Branch Name: pr-457
1 out of 1jobs PASSEDBranch GIT ID: 3254602bc513f9c04f35939b3d10388f761cb4cc
1 Successful Jobs:
For more details click here.