LPS-101624, LPS-101625 Deprecate Liferay.Util.isTablet and Liferay.Util.isPhone
#87789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Util.isPhone` Originally discussed in https://github.com/wincent/liferay-portal/pull/206 The goal of these changes is to mark `Liferay.Util.isTablet` and `Liferay.Util.isPhone` as deprecated. We're also providing these functions as "modules" so that they can easily be imported projects that use ES6.
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
@brianchandotcom yes of course. |
|
/cc @mateomustapic please check dea258f too. |
liferay-continuous-integration
deleted the
ci-forward-LPS-101625-pr-213-sender-julien-ts-1587412464315
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: https://github.com/wincent/liferay-portal/pull/213
@julien
@wincent
Original pull request comment:
Originally discussed in #206
The goal of these changes is to mark
Liferay.Util.isTabletandLiferay.Util.isPhoneas deprecated. We're also providing these functions as "modules" so that
they can easily be imported projects that use ES6.
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 10 seconds 636 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 296ff93c5fcb45f4659fa3049cc3c74d7dcb6414
Sender Branch:
Branch Name: LPS-101625
1 out of 1jobs PASSEDBranch GIT ID: 5691eb49d081e010f93f6b6ef5be2f9ce60c9450
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 17 out of 17 jobs passed
✔️ ci:test:relevant - 33 out of 33 jobs passed in 1 hour 15 minutes 22 seconds 491 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 4cf384e0e7e1045aeb93b03a9330527cd7c0786b
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: b4536024712dac54820c4c13f7cf737b2b7a945b
ci:test:stable - 17 out of 17 jobs PASSED
17 Successful Jobs:
ci:test:relevant - 33 out of 33 jobs PASSED
33 Successful Jobs:
For more details click here.