Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-101646 Deprecate Liferay.Util.sortByAscending #87892

Closed
wants to merge 6 commits into from
Closed

LPS-101646 Deprecate Liferay.Util.sortByAscending #87892

wants to merge 6 commits into from

Commits on Apr 22, 2020

  1. LPS-101646 Deprecate Liferay.Util.sortByAscending

    @wincent
    Julien Castelain authored and wincent committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    6a6efca View commit details
    Browse the repository at this point in the history

  2. LPS-101646 Inline sort function 

    As discussed here
https://github.com/wincent/liferay-portal/pull/216#discussion_r411505495,
there is not need to expose this function, we can just inline it.
    @wincent
    Julien Castelain authored and wincent committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    ec23564 View commit details
    Browse the repository at this point in the history

  3. LPS-101646 Fix @deprecated comment 

    Updated `@deprecated` comment based on
brianchandotcom@dea258f
    @wincent
    Julien Castelain authored and wincent committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    54da79a View commit details
    Browse the repository at this point in the history

  4. LPS-101646 Remove dead variable

    @wincent
    Julien Castelain authored and wincent committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    3fe8950 View commit details
    Browse the repository at this point in the history

  5. LPS-101646 Fix JSDoc comment 

    Based on
https://github.com/wincent/liferay-portal/pull/216#discussion_r412098729,
this should be the correct format for the @deprecated JSDoc comment when
there is no direct replacement for a function
    @wincent
    Julien Castelain authored and wincent committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    9cc4547 View commit details
    Browse the repository at this point in the history

  6. LPS-101646 Fix comment damage

    @wincent
    wincent committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    48741f1 View commit details
    Browse the repository at this point in the history