LPS-101646 Deprecate Liferay.Util.sortByAscending #87892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed here https://github.com/wincent/liferay-portal/pull/216#discussion_r411505495, there is not need to expose this function, we can just inline it.
Updated `@deprecated` comment based on brianchandotcom@dea258f
Based on https://github.com/wincent/liferay-portal/pull/216#discussion_r412098729, this should be the correct format for the @deprecated JSDoc comment when there is no direct replacement for a function
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-julien/LPS-101646/sort-by-ascending-pr-227-sender-wincent-ts-1587635993848
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: https://github.com/wincent/liferay-portal/pull/227
@wincent
Original pull request comment:
This is a rebase and resend of https://github.com/wincent/liferay-portal/pull/216, which got wedged in CI, and I had to add one additional commit on top anyway.
cc @julien
✔️ ci:test:stable - 18 out of 18 jobs passed
✔️ ci:test:relevant - 33 out of 33 jobs passed in 1 hour 18 minutes 44 seconds 215 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 3c8512dc34aa2ec5b689885069ce2a5d92f9cb21
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: b4536024712dac54820c4c13f7cf737b2b7a945b
ci:test:stable - 18 out of 18 jobs PASSED
18 Successful Jobs:
ci:test:relevant - 33 out of 33 jobs PASSED
33 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 45 seconds 925 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: faa199a7fa798cec664629b42fd5ca4ebe420dd3
Sender Branch:
Branch Name: julien/LPS-101646/sort-by-ascending
1 out of 1jobs PASSEDBranch GIT ID: 48741f17342ac1176c390eb34ba514c978a70a92
1 Successful Jobs:
For more details click here.