LPS-111979 Center CKEditor dialogs #88346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this fix is to "center" CKEditor's dialogs. Since our recent change to use CKEditor in more places, CKEditor dialogs are now aligned in the top left corner instead of being centered. The only previous commit I could find concerning this file is in [https://github.com/liferay/liferay-portal/commit/a4df2c65a8fb39c139e0e9781078b2092c868f68](https://github.com/liferay/liferay-portal/commit/a4df2c65a8fb39c139e0e9781078b2092c868f68), when the file was initially added.
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-111979-pr-247-sender-julien-ts-1588673711796
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: https://github.com/wincent/liferay-portal/pull/247 (Took 1
ci:forwardattempt in 1 minute)@julien
@wincent
Original pull request comment:
The goal of this fix is to "center" CKEditor's dialogs.
Since our recent change to use CKEditor in more places, CKEditor dialogs
are now aligned in the top left corner instead of being centered.
The only previous commit I could find concerning this file is in
liferay@a4df2c6,
when the file was initially added.
✔️ ci:test:stable - 18 out of 18 jobs passed
✔️ ci:test:relevant - 30 out of 30 jobs passed in 1 hour 10 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 407d32565f0bcb4442c26f07f1f404488ff7c609
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: b4536024712dac54820c4c13f7cf737b2b7a945b
ci:test:stable - 18 out of 18 jobs PASSED
18 Successful Jobs:
ci:test:relevant - 30 out of 30 jobs PASSED
30 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: a2cae1b7f7f1638f9b8cd9fb75f475bf422037fe
Sender Branch:
Branch Name: LPS-111979
1 out of 1jobs PASSEDBranch GIT ID: 379087f3d5332b4c3bfcd7a2354be6c38cd3137f
1 Successful Jobs:
For more details click here.