LPS-113582|LPS-113583 Replaces the usages of Liferay.Notification and Liferay.Notice with Liferay.Util.openToast
#90226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he given string is a HTML or not, uses a property for using `title` and `message ` as HTML in openToast utility. From: jbalsas#2179 (comment)
…and use directly `dangerouslySetInnerHTML` on Text component
… Liferay.Util.openToast
…penToast` Found usages via: `git grep '\bLiferay\.Notification\b'` `git grep liferay-notification`
Usages were found running `git grep '\bLiferay\.Notice\b'` `git grep liferay-notice` `Liferay.Util.openToast` utility was created for opening toasts and considering that Notice usages are for opening dismissible toasts, I could replace directly
…of Liferay.Notice AUI component and Liferay.Notice usages were replaced with `openToast` and ClayAlerts doesn't have animations
…s defined in whole file, these default values aren't needed
`React will automatically append a “px” suffix to certain numeric inline style properties.` From: https://reactjs.org/docs/dom-elements.html
… with the counter equal 1
…ring markup. For some cases in JSPs, HTML strings are being passed to openToast.
…he given string is a HTML or not, uses a property for using `title` and `message ` as HTML in openToast utility. From: jbalsas#2179 (comment)
…and use directly `dangerouslySetInnerHTML` on Text component
Early this property was being used for handling the instance of the Liferay.Notice component but now it's unnecessary
…in and wasn't using it. However, it was using `aui-alert` but not declaring it. `liferay-notice` depends on `aui-alert` and I'm assuming that it was working due to this
…ser don't pass the title/message value React will not throw an error trying to render undefined
… For avoiding breaking changes
… use `messageType` and `titleType` for handling toast contents
Apparently another module was calling `plugin` module and It was working in the past due to this and this dep wasn't described on the `liferay-session` module. Adding as a dependency of `liferay-session` solves the problem
…sion` In some cases, apparently depending on the hardware, `aui-component` is not being loaded causing an error not localizing `A.component` on session AUI component
|
Closing pull request because all |
|
ci:reopen |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual forward from liferay-frontend#5
ci:test:relevantfailed with:Thank you to @john-co (comment) and @rodrigocunhaa (comment) for investigating and confirming that the failure is unrelated.
cc @diegonvs
Original description follows.
Forwarded here from wincent#309, where it was stuck in CI hell. Let's see if we have any better luck over here.
Original description:
cc @diegonvs @jbalsas