Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-116201 Update liferay-ckeditor version in portal and implement changes to make it fit with new skin #91140

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-frontend#66 (Took 1 ci:forward attempt in 2 minutes)

@carloslancha
@liferay-frontend

Original pull request comment:
https://issues.liferay.com/browse/LPS-116201

Updating liferay-ckeditor version in portal in order to apply the new skin we created following Lexicon's specs.

icon states

Test plan:

  • Go to Product Menu / Content & Data / Web Content / New Basic Web Content (or ay other place with an editor)
  • Play with the editor, check the icons and the styling.

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0d4e186949c11ac3fdec84f9a8efb73f3370c405

Sender Branch:

Branch Name: LPS-116201-moono-lexicon
Branch GIT ID: fc51c83366255e639af50871254b71eb6f47ad4a

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

✔️ ci:test:stable - 20 out of 20 jobs passed

✔️ ci:test:relevant - 52 out of 52 jobs passed in 1 hour 14 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 678e0cdde7e1364a6cbd1db1ac673384542da199

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 26d9c30572aa163b37c2bdb9a90c3ef3cbf122b3

ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 52 out of 52 jobs PASSED
52 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: b30b4c4...ca74d5c

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-116201-moono-lexicon-pr-66-sender-carloslancha-ts-1594322860641 branch July 17, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants