LPS-115260 As an account manager, I want to create account users from an account's details page #91268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rol showing the create button in the users modal
…rs for a business type account
…ponent constructor so that the selectAccountUsers function can be called in the attached method
…users modal state
…n modal state and opens the modal if found
…ing the add button in the modal
…create button was clicked from a different context
…l toolbar even handler for consistency
…n role users dialog
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
|
@drewbrokke I did dd13847 can you do the rest in your modules. Thx. |
liferay-continuous-integration
deleted the
ci-forward-LPS-115260-STORY-v1-create-account-users-modal-un-namespace-pr-660-sender-drewbrokke-ts-1594666759316
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: pei-jung#660 (Took 1
ci:forwardattempt in 2 minutes)@drewbrokke
@pei-jung
Original pull request comment:
This is an update for LPS-115260.
Hey Pei, I went ahead and removed the namespacing. I didn't get an answer on it so I'm gonna play it safe for now.
/cc @pei-jung @alee8888 @ChrisKian @dejuknow @patriciajeanperez
✔️ ci:test:stable - 20 out of 20 jobs passed
✔️ ci:test:relevant - 46 out of 46 jobs passed in 1 hour 59 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: fcffc8af664fd67a6f1fd01a460824265f35349a
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: 2d61577aa6a76425e17132e68f5aa901f720a686
ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 46 out of 46 jobs PASSED
46 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: fcffc8af664fd67a6f1fd01a460824265f35349a
Sender Branch:
Branch Name: LPS-115260-STORY-v1-create-account-users-modal-un-namespace
1 out of 1jobs PASSEDBranch GIT ID: 3f33c866303cbcb653357680b64fd124676dee31
1 Successful Jobs:
For more details click here.