LPS-116757 Configuration Search not working implementing VisibilityController #91339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sibilityController to a new static util
… filtering by visibility for ConfigurationModelRetriever
…er the filtered or unfiltered ConfigurationModelRetriever
… the original impl of ConfigurationModelRetriever
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
|
@drewbrokke see d4c5644 |
liferay-continuous-integration
deleted the
ci-forward-LPS-116757-BUG-v0-visibility-controller-search-pr-1125-sender-drewbrokke-ts-1594758139592
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: drewbrokke#1125 (Took 1
ci:forwardattempt in 1 hour 27 minutes)@drewbrokke
Original pull request comment:
This is an update for LPS-116757.
/cc @pei-jung @alee8888 @ChrisKian @dejuknow @patriciajeanperez
✔️ ci:test:stable - 20 out of 20 jobs passed
✔️ ci:test:relevant - 44 out of 44 jobs passed in 1 hour 25 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 52e76f1e1b7a01b4d962b79ff403f0d0c2f56fe3
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: 2d61577aa6a76425e17132e68f5aa901f720a686
ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 44 out of 44 jobs PASSED
44 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 52e76f1e1b7a01b4d962b79ff403f0d0c2f56fe3
Sender Branch:
Branch Name: LPS-116757-BUG-v0-visibility-controller-search
1 out of 1jobs PASSEDBranch GIT ID: ab67492bac31e1d6d80b2c43decdec48294be51e
1 Successful Jobs:
For more details click here.