LPS-117287 Web Content article Publish button stops working #91893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#171 (Took 1
ci:forward
attempt in 6 minutes)@markocikos
@liferay-frontend
Original pull request comment:
This is a bugfix, see description in https://issues.liferay.com/browse/LPS-117287
The issue is caused by CKEditor and AlloyEditor(s) on the same page. There is a race condition on navigate (back or Publish), and CKEditor instance may delete
CKEDITOR
global object before AlloyEditor instances are destroyed. This is the same fix as in React-based Editor and AlloyEditor.The race scenario causes Publish button to sporadically stops working, and this PR fixes it. But, the console error in ticket description does not match this scenario. The error that happens is
The error in ticket description is
I sporadically got this error when quickly navigating before page loads, and this PR does not fix it. But, this error looks unrelated to the problem of this ticket:
CKEDITOR
, happens around every 20+ navigations, while undefined happens every 3-4 times and can be reliably provokedCKEDITOR
happens once when navigating away from page, and breaks a lot of UI.I gave up on trying to find the root cause of
data
issue, as it looks to be deep in base CKeditor. I think we can ignore it for now.✔️ ci:test:stable - 20 out of 20 jobs passed
✔️ ci:test:relevant - 45 out of 45 jobs passed in 2 hours 32 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: ae294d94fe8f2a5d93da8fc5714cd71e5908eb9d
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: 2aa558d7587a046d654b60e91d9b21cb5e106df3
ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 45 out of 45 jobs PASSED
45 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: ae294d94fe8f2a5d93da8fc5714cd71e5908eb9d
Sender Branch:
Branch Name: LPS-117287
1 out of 1jobs PASSEDBranch GIT ID: 1ac26c6284924cc073d555d6f90d32d84bb5a6bc
1 Successful Jobs:
For more details click here.