LPS-114149 Remove logic that was setting placeholder to BLANK on IE >=10 #92220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…=10. IE10 is no longer supported and behavior described in LPS-73502 is no longer reproducible in IE11.
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-114149-ie11-placeholder-pr-201-sender-carloslancha-ts-1596539161369
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#201 (Took 1
ci:forwardattempt in 3 minutes)@carloslancha
@liferay-frontend
Original pull request comment:
Removing logic that was setting placeholder to BLANK on IE >=10.
IE10 is no longer supported and behavior described in LPS-73502, where this fix was introduced in the first place, is no longer reproducible in IE11.
Steps to reproduce:
Using IE11
✔️ ci:test:stable - 13 out of 13 jobs passed
✔️ ci:test:relevant - 34 out of 34 jobs passed in 4 hours 2 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: fc41ffa140788c094638ac1f5494781ee8770005
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: a2989be147835c295b16fd5637140c9d4cd9de61
ci:test:stable - 13 out of 13 jobs PASSED
13 Successful Jobs:
ci:test:relevant - 34 out of 34 jobs PASSED
34 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: fc41ffa140788c094638ac1f5494781ee8770005
Sender Branch:
Branch Name: LPS-114149-ie11-placeholder
1 out of 1jobs PASSEDBranch GIT ID: 0293463bdcf81b3e9caab5ca94ac2d77a48cfa3c
1 Successful Jobs:
For more details click here.