Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-121262 Handle hyphens in topics names #94600

Closed
wants to merge 1 commit into from
Closed

LPS-121262 Handle hyphens in topics names #94600

wants to merge 1 commit into from

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-headless#418 (Took 1 ci:forward attempt in 1 hour 54 minutes)

@LuismiBarcos
@liferay-headless

✔️ ci:test:sf - 1 out of 1 jobs passed in 25 seconds

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d44dff9c7fa409cd020c78648064da278dda846d

Sender Branch:

Branch Name: LPS-121262
Branch GIT ID: d788060d52aa64d2ef09c45c4c69d26f9ea4c879

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

✔️ ci:test:stable - 20 out of 20 jobs passed

✔️ ci:test:relevant - 44 out of 44 jobs passed in 1 hour 52 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 60d91be287a3416b0608ad05c8591bed6deb5a77

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 128d69f3cb43c55e817636ad73b18147091c6836

ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 44 out of 44 jobs PASSED
44 Successful Jobs:
For more details click here.

Closed
@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@brianchandotcom
Copy link
Owner

@LuismiBarcos sort:

	const whiteSpaces = /\s+/g;
	const hyphens = /-+/g;

to

	const hyphens = /-+/g;
	const whiteSpaces = /\s+/g;

For

	slug = slug.replace(hyphens, ' ');
	slug = slug.replace(encodedHyphens, '-').toLowerCase();

I need to know if order matters. If order matters, add a line break. If not, sort the replaces.

Please add tests for this kind of stuff.

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-121262-pr-418-sender-LuismiBarcos-ts-1601287471978 branch October 5, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
2 participants
@liferay-continuous-integration @brianchandotcom