LPS-122399 Update loader-related frontend dependencies #95173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**:information_source: This is safe to backport to 7.3.x.** These are just maintenance updates to reflect the migration of the `liferay-amd-loader` project to the named scope (ie. `@liferay/amd-loader`) version of the package. There should be no behavioral changes, but this bring the project into a namespace that we fully control. There are some cascading side-effects of this, which mean that we have to additionally update `@liferay/npm-bundler-preset-liferay-dev` (because it references the loader), which in turn means we must update `@liferay/npm-scripts` (because it references the preset). Finally, we have to update `@liferay/npm-bundler` because it references the loader too. Release notes for all of these: - https://github.com/liferay/liferay-frontend-projects/releases/tag/amd-loader%2Fv4.3.1 - https://github.com/liferay/liferay-frontend-projects/releases/tag/npm-bundler-preset-liferay-dev%2Fv4.6.5 - https://github.com/liferay/liferay-frontend-projects/releases/tag/npm-scripts%2Fv33.1.4 - https://github.com/liferay/liferay-frontend-projects/releases/tag/npm-bundler%2Fv3.0.1
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
|
@wincent thx. I backported this to 7.3.x |
liferay-continuous-integration
deleted the
ci-forward-wincent/LPS-122399/frontend-package-updates-pr-437-sender-wincent-ts-1603232587719
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#437 (Took 1
ci:forwardattempt in 1 minute)@wincent
@liferay-frontend
Original pull request comment:
ℹ️ This is safe to backport to 7.3.x.
These are just maintenance updates to reflect the migration of the
liferay-amd-loaderproject to the named scope (ie.@liferay/amd-loader) version of the package. There should be no behavioral changes, but this bring the project into a namespace that we fully control.There are some cascading side-effects of this, which mean that we have to additionally update
@liferay/npm-bundler-preset-liferay-dev(because it references the loader), which in turn means we must update@liferay/npm-scripts(because it references the preset). Finally, we have to update@liferay/npm-bundlerbecause it references the loader too.Release notes for all of these:
✔️ ci:test:sf - 1 out of 1 jobs passed in 0 ms
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: f0ec6d0403116a53dc4fd6745e107f29b53b0558
Sender Branch:
Branch Name: wincent/LPS-122399/frontend-package-updates
1 out of 1jobs PASSEDBranch GIT ID: 5f91741aacc63e4a7b44bd8ca6734ba8e1affbd7
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 14 out of 14 jobs passed
✔️ ci:test:relevant - 42 out of 42 jobs passed in 1 hour 46 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: f0ec6d0403116a53dc4fd6745e107f29b53b0558
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: 27bc57847a0fbdd19ff9c855a0e2eda43d622c23
ci:test:stable - 14 out of 14 jobs PASSED
14 Successful Jobs:
ci:test:relevant - 42 out of 42 jobs PASSED
42 Successful Jobs:
For more details click here.