Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lps 123057 #95938

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: drewbrokke#1226 (Took 1 ci:forward attempt in 3 minutes)

@mtambara
@drewbrokke

Original pull request comment:
Made some changes, let me know if this still fits your requirements

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 22 jobs passed in 1 hour 53 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e066954b019e5fcf42ca45b69fd4da595ad58029

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 22 out of 22 jobs PASSED
22 Successful Jobs:
For more details click here.

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 06e707df4454e36051558b8c5deaf7600497f9ab

Sender Branch:

Branch Name: LPS-123057
Branch GIT ID: 243cdac28f51badb7100fa82ac7ee291d4b1b782

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@drewbrokke
Copy link

cc @jeyvison

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 61640de...bea015b

@brianchandotcom
Copy link
Owner

Wow wow wow.. this is a big deal.

@rsezov @jrhoun we need to get this into Liferay Learn once FP1 is out.

@mtambara can you update that LPS with more real world examples? I assume you factored in conflicts so that different modules can't conflict with each other?

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-123057-pr-1226-sender-mtambara-ts-1605298838537 branch November 21, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants