LPS-124415 [Back] Create traffic source detail representation for SOCIAL traffic #96637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
|
@darquesdev see 402623a |
liferay-continuous-integration
deleted the
ci-forward-LPS-124415-pr-637-sender-darquesdev-ts-1607085714943
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-tango#637 (Took 1
ci:forwardattempt in 1 minute)@darquesdev
@liferay-tango
Original pull request comment:
Motivation:
This PR provides a representation for the second level of social traffic: a list of referring social media with the correspoding traffic.
{ "name":"social", "share":"90,0", "title":"Social", "referringSocialMedia":[ { "name":"twitter", "trafficAmount":1165, "title":"Twitter" }, { "name":"other", "trafficAmount":30, "title":"Other" } ], "value":5532, "helpMessage":"This is the number of page views generated by people coming to your page from social sites." }Solution:
Add a new property to
SocialTrafficChannelImplthat represents the referring social media and add update the toJSONObject accordingly to include the new property.How to test it:
Unit tests have been included
✔️ ci:test:stable - 9 out of 9 jobs passed
✔️ ci:test:relevant - 21 out of 21 jobs passed in 2 hours 51 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 8eebb07a14c6528941d9dbe9144a7ae63f00999e
Copied in Private Modules Branch:
Branch Name: master-private
Branch GIT ID: 22478fba589bf9dfa1ff6225fb25ee8fcbb03693
ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 21 jobs PASSED
21 Successful Jobs:
For more details click here.
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 13e82005940e2f8b2d58d2fbfd7fa8400477dc20
Sender Branch:
Branch Name: LPS-124415
1 out of 1jobs PASSEDBranch GIT ID: 6d867f8b3503e0c53e93155fbcb13bd470437c6d
1 Successful Jobs:
For more details click here.