Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-124870 Use disabled input ID box in click goal target instead of link #96994

Closed
wants to merge 6 commits into from
Closed

LPS-124870 Use disabled input ID box in click goal target instead of link #96994

wants to merge 6 commits into from

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-frontend#620 (Took 1 ci:forward attempt in 1 minute)

@dgarciasarai
@liferay-frontend

Original pull request comment:
Description
From a feature request, we are going to add the ability of selecting any element as a click target along with the OOTB ones (button and links with ID).

Solution

  • Display a different message inside the Click goal section: "Select a clickable element to be measured using the select button or by entering its ID in the field below."
  • Change "Set Element" and "Edit Element" button copies to "Select Clickable Element" and "Change Clickable Element"
  • Use a ClayInput (disabled for now, but in the next sub-task is to be enable to let the user write its ID) instead of a link to display the selected ID, with a label "Element ID" and a help text (question-circle icon). The input has also a tooltip with the selected target
  • Selected target is now displaying without # inside the input. Tooper and Popover in the highlighted clickable elements (buttons or links with ID) remains the same (with #)
  • View button (eye button) does the same as the previous link: scroll to the selected target and hightlights
  • goalTarget is stored in the database with the same format as before (#myId)

Screenshots

Screenshot 2020-12-15 at 11 23 45 Screenshot 2020-12-15 at 11 23 59
Screenshot 2020-12-15 at 11 33 11 Screenshot 2020-12-15 at 10 36 27

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 1 hour 32 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 012adf4b2836179a5478bf04b5337955917fccb8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 0ff04d9f73a4643abdd2b335581feef26b985b8a

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 23 out of 23 jobs PASSED
23 Successful Jobs:
For more details click here.

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 012adf4b2836179a5478bf04b5337955917fccb8

Sender Branch:

Branch Name: LPS-124870
Branch GIT ID: 4739d446793548b4db655bf4072969698bebba50

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

Closed
@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: c273cec...f92502c

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-124870-pr-620-sender-dgarciasarai-ts-1608128525257 branch December 24, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@liferay-continuous-integration @brianchandotcom @dgarciasarai