-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minified version #32
Comments
It would be a "nice-to-have" convenience, though it would put the onus of remembering to minify before pushing/releasing onto the plugin developer(s). Although this is admittedly an embarrassingly scriptable process, it could be mildly disruptive to the plugin development process going forward in that it would force a habit change. @briancherne will ultimately decide whether or not the convenience of an unknown subset of the plugin users is worth further amending his development process, but in the meantime, interested folks can '+1' or subscribe to this issue as a sort of implicit vote (one can also '-1' if for any reason one has strong objections). |
As it happens, for the particular project I'm working on I ended up concatenating the plugins before minifying them. So I didn't require a minified source version in the end. However, plugin developers providing a standard and minified version of a script is still a good idea IMO. Agreed though, that it's easier if the developer is already in the habit of working with a src/dist/tests type of automated workflow. |
I can see the benefit of having a standard/approved minified version (I offer one on my web site, not tied to the github repo), but as @usmonster mentions it would require a change in development process... thus work. I'd like to see 3 people "+1" this issue/feature request before we add it, or close it after a year of inactivity. |
+1 |
1 similar comment
+1 |
+1 |
+1 |
FYI, a minified file will be included in the upcoming version, so the poll requires no more votes. :) Thanks to all who made the desire for this feature known! |
+1 |
After several years, this issue has finally been addressed in the PR #64. Any interested person can feel free to review the PR and leave comments (there are already some open questions there), or it will be merged within the next two weeks. Thanks! |
Also adds script to build it. Closes briancherne#32.
Any chance of including a minified version of the file?
That way I can skip a step in my grunt workflow, i.e. just copy the file straight to wherever I need it, rather than having to uglify it first.
The text was updated successfully, but these errors were encountered: