Reuse over handler if out is not given
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bug where, if the plugin was initialized with a configuration object, it wouldn't check whether the (optional) `out` function was provided before attempting to use it. This resulted in an error. In this case, it now reuses the (required) `over` function. Closes briancherne#42.
usmonster
added a commit
that referenced
this pull request
Nov 27, 2015
Reuse `over` handler if `out` is not given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug where, if the plugin was initialized with a configuration
object, it wouldn't check whether the (optional)
outfunction wasprovided before attempting to use it. This resulted in an error.
In this case, it now reuses the (required)
overfunction.Closes #42.