Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Error handling #37

Closed
andrzejWilde opened this issue Jan 6, 2014 · 1 comment
Closed

Wrong Error handling #37

andrzejWilde opened this issue Jan 6, 2014 · 1 comment
Labels

Comments

@andrzejWilde
Copy link

In SourceNode.prototype.renderVideo method there's try-catch statement. The catch part is incorrect - the name of the Error may probably vary among browsers - for Safari for instance it is "SecurityError" while you're checking against "SECURITY_ERR". Also, there should definitely be some "else" there - otherwise the error can't be spotted in any way.

To sum up, if you try CORS request in Safari you'll fail but also you won't get any feedback whatsoever.

@brianchirls
Copy link
Owner

Thanks for reporting, Andrzej. Good catch. I'll check the error code instead of name, which is the same in Safari. (We already do this in the checkSource utility.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants