Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for analytics.js #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jstoeffler
Copy link

No description provided.

@therasin
Copy link

therasin commented Aug 1, 2014

J, Are your changes designed to make phpabtest work with Universal Analytics? If so can you point me to how to set it up in Universal Analytics to sync with your version of phpabtest, have yet to use the new version.

@jstoeffler
Copy link
Author

@therasin Yes it is. It's designed for the universal analytics code. You just use like the normal version of phpab : include the file, define the test,...

It should be documented, and maybe improved a bit, but I don't have the time for that.

Either you understand how it works, or the author merges my pull request and adds the documentation (which I think would make sense).

}
else
{
error_log("ASYNC:".$async);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, you still have error logs in here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed that for you

@jstoeffler
Copy link
Author

@briancray What are your thoughts this PR ? analytics.js is now the recommended way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants