Skip to content

Commit

Permalink
ed: simplify edWrite() (#553)
Browse files Browse the repository at this point in the history
* Similar to previous patch in edEdit(), avoid assignment of $RememberedFilename into itself if $args[0] is not set
* The empty string check for $args[0] done in edEdit() is not needed here because the input was already passed through the main parse-commads regex
  • Loading branch information
mknos committed Apr 14, 2024
1 parent 15e2360 commit e3651c1
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions bin/ed
Original file line number Diff line number Diff line change
Expand Up @@ -623,14 +623,14 @@ sub edWrite {
}
}

$filename = defined($args[0]) ? $args[0] : $RememberedFilename;

if (!defined($filename)) {
if (defined $args[0]) {
$filename = $RememberedFilename = $args[0];
} elsif (defined $RememberedFilename) {
$filename = $RememberedFilename;
} else {
edWarn(E_NOFILE);
return;
}
$RememberedFilename = $filename;

my $mode = $AppendMode ? '>>' : '>';
unless (open $fh, $mode, $filename) {
warn "$filename: $!\n";
Expand Down

0 comments on commit e3651c1

Please sign in to comment.