Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: simplify edWrite() #553

Merged
merged 1 commit into from
Apr 14, 2024
Merged

ed: simplify edWrite() #553

merged 1 commit into from
Apr 14, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 14, 2024

  • Similar to previous patch in edEdit(), avoid assignment of $RememberedFilename into itself if $args[0] is not set
  • The empty string check for $args[0] in edEdit() is not needed here because the input was already passed through the main parse-commads regex

@mknos
ed: simplify edWrite()
055f1ee 
* Similar to previous patch in edEdit(), avoid assignment of $RememberedFilename into itself if $args[0] is not set
* The empty string check for $args[0] done in edEdit() is not needed here because the input was already passed through the main parse-commads regex
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Apr 14, 2024
@briandfoy briandfoy self-assigned this Apr 14, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Apr 14, 2024
@briandfoy briandfoy merged commit e3651c1 into briandfoy:master Apr 14, 2024
1 of 2 checks passed
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy