Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shar: dependency error #300

Merged
merged 1 commit into from
Oct 23, 2023
Merged

shar: dependency error #300

merged 1 commit into from
Oct 23, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 22, 2023

  • shar did not work on my system: Can't locate getopts.pl in @inc (@inc contains: /usr/local/lib/perl5/site_perl/5.34.1/armv7l-linux ...)

  • The original intent of getopt was to raise error for any options (e.g. -x), so convert to Getopt::Std

  • Add strict

  • Tested this by creating archive (perl shar ar apply > new.shar) then extracting (sh new.shar)

* shar did not work on my system: 
 Can't locate getopts.pl in @inc (@inc contains: /usr/local/lib/perl5/site_perl/5.34.1/armv7l-linux ...)

* The original intent of getopt was to raise error for any options (e.g. -x), so convert to Getopt::Std
* Add strict
* Tested this by creating archive (perl shar ar apply > new.shar) then extracting (sh new.shar)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: shar The shar program labels Oct 22, 2023
@briandfoy
Copy link
Owner

heh, that's some old school Perl 4 libraries there :)

@briandfoy briandfoy self-assigned this Oct 23, 2023
@briandfoy
Copy link
Owner

Hey, I've approved this PR but I'm going to wait a minute to merge it. I'm trying to work out some GitHub Actions for merging, so I want to have something real to merge.

@briandfoy briandfoy closed this Oct 23, 2023
@briandfoy briandfoy reopened this Oct 23, 2023
@briandfoy
Copy link
Owner

I pushed the wrong button. I didn't mean to close this.

@briandfoy briandfoy merged commit b18aa3d into briandfoy:master Oct 23, 2023
2 of 3 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 23, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: shar The shar program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants