Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comm: use strict #306

Merged
merged 1 commit into from
Oct 27, 2023
Merged

comm: use strict #306

merged 1 commit into from
Oct 27, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 27, 2023

  • Add strict as done in other scripts
  • COL[1] is the first element; COL[0] is a placeholder
  • For my sample input files, the output is identical compared to previous version
  • GNU comm prints a warning if input files are not sorted, but this version doesn't

@mknos
comm: use strict
d965c24 
* Add strict as done in other scripts
* COL[1] is the first element; COL[0] is a placeholder
* For my sample input files, the output is identical compared to previous version
* GNU comm prints a warning if input files are not sorted, but this version doesn't
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: comm The comm program labels Oct 27, 2023
@briandfoy briandfoy merged commit bcd7440 into briandfoy:master Oct 27, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 31, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees
No one assigned
Labels
Program: comm The comm program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy