Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printf: hex & octal escapes #528

Merged
merged 1 commit into from
Apr 3, 2024
Merged

printf: hex & octal escapes #528

merged 1 commit into from
Apr 3, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 3, 2024

  • When testing against bash-builtin and GNU version of printf command, octal escapes allow 3 digits but input >255 are interpreted as mod-256 (e.g. \400 wraps around to \0)
  • For hex escapes, only 2 digits are allowed so entering input above FF is not possible anyway
  • The hex digits can be mixed case, but the "x" prefix must be lowercase
  • test1: terminate word list with NUL: perl printf '%s\0' over here
  • test2: windows line-ending string with hex: perl printf 'hey\xd\xa'

@mknos
printf: hex & octal escapes
be89018 
* When testing against bash-builtin and GNU version of printf command, octal escapes allow 3 digits but input >255 are interpreted as mod-256 (e.g. \400 wraps around to \0)
* For hex escapes, only 2 digits are allowed so entering input above FF is not possible anyway
* The hex digits can be mixed case, but the "x" prefix must be lowercase
* test1: terminate word list with NUL: perl printf '%s\0' over here
* test2: windows line-ending string with hex: perl printf 'hey\xd\xa'
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: printf The printf program labels Apr 3, 2024
@briandfoy briandfoy self-assigned this Apr 3, 2024
@briandfoy briandfoy merged commit 67ceb17 into briandfoy:master Apr 3, 2024
1 of 2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Apr 3, 2024
@briandfoy
Copy link
Owner

changes: handle octal and hex escapes better (and limit to a single char)

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: printf The printf program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy