Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bc: avoid extra copy of filehandle #543

Merged
merged 1 commit into from
Apr 11, 2024
Merged

bc: avoid extra copy of filehandle #543

merged 1 commit into from
Apr 11, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 11, 2024

  • In next_file(), the old filehandle $input is closed if we're not processing the 1st file
  • The filehandle $input is global; open it directly instead of copying into it from "IN"
  • IN was not referenced anywhere else in the program

@mknos
bc: avoid extra copy of filehandle
faa2b00 
* In next_file(), the old filehandle $input is closed if we're not processing the 1st file
* The filehandle $input is global; open it directly instead of copying into it from "IN"
* IN was not referenced anywhere else in the program
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: bc The bc program labels Apr 11, 2024
briandfoy
briandfoy approved these changes Apr 11, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, that's one of those weird coding things where the author was probably thinking of something else and never came back to clean this up. We have all been there.

@briandfoy briandfoy merged commit 710e954 into briandfoy:master Apr 11, 2024
1 of 2 checks passed
@briandfoy briandfoy self-assigned this Apr 11, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Apr 11, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: bc The bc program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy