Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split: refactor get_count() #555

Merged
merged 1 commit into from
Apr 15, 2024
Merged

split: refactor get_count() #555

merged 1 commit into from
Apr 15, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 15, 2024

  • Rewrite validation routine to use only 1 regex, which extracts the number prefix and optional multiplier suffix
  • Remove warnings for users
  • The following are valid for -b argument: 1, 1k, 1K, 1m, 1M (not 0 and not empty string)

@mknos
split: refactor get_count()
db9c5ab 
* Rewrite validation routine to use only 1 regex, which extracts the number prefix and optional multiplier suffix
* Remove warnings for users
* The following are valid for -b argument: 1, 1k, 1K, 1m, 1M (not 0 and not empty string)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: split The split program labels Apr 15, 2024
@briandfoy briandfoy self-assigned this Apr 15, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Apr 15, 2024
@briandfoy briandfoy merged commit 0ea12dc into briandfoy:master Apr 15, 2024
1 of 2 checks passed
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: split The split program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy