Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fold: simplify fold_file() #561

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fold: simplify fold_file() #561

merged 1 commit into from
Apr 16, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 16, 2024

  • The -b flag (bytes only) affects all file arguments
  • fold_file() was actually 2 functions; it contained the code for folding in byte-only mode, with early return
  • Declare a fold_file_byte() to clarify that column (default) and byte modes are separate
  • Update the error message for failure of close() to include $!

@mknos
fold: simplify fold_file()
cba569c 
* The -b flag (bytes only) affects all file arguments
* fold_file() was actually 2 functions; it contained the code for folding in byte-only mode, with early return
* Declare a fold_file_byte() to clarify that column (default) and byte modes are separate
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: fold The fold program labels Apr 16, 2024
@briandfoy briandfoy self-assigned this Apr 16, 2024
@briandfoy briandfoy merged commit 990edb4 into briandfoy:master Apr 16, 2024
2 checks passed
@briandfoy
Copy link
Owner

changes: better error messages when fold can't close a file properly

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Apr 16, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: fold The fold program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy