Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tr: pod update #636

Merged
merged 1 commit into from
Jun 4, 2024
Merged

tr: pod update #636

merged 1 commit into from
Jun 4, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 4, 2024

  • Remove mention of open() failures in BUGS section of manual
  • Similar to bin/tee and bin/xargs, change the loop to read STDIN to make it more obvious that tr does not open any files
  • On my Linux system, if I redirect stdin from /etc/shadow as a regular user, bash shows a permissions error and sets $? to 1; this takes place before perl is started
  • Remove header comment that is duplicated in pod

@mknos
tr: pod update
0bd5306 
* Remove mention of open() failures in BUGS section of manual
* Similar to bin/tee and bin/xargs, change the loop to read STDIN to make it more obvious that tr does not open any files
* On my Linux system, if I redirect stdin from /etc/shadow as a regular user, bash shows a permissions error and sets $? to 1; this takes place before perl is started
* Remove header comment that is duplicated in pod
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tr The tr program labels Jun 4, 2024
@briandfoy briandfoy added Type: documentation fix the docs and removed Type: enhancement improve a feature that already exists labels Jun 4, 2024
briandfoy
briandfoy approved these changes Jun 4, 2024
View reviewed changes
bin/tr Show resolved Hide resolved
@briandfoy
Copy link
Owner

changes: tr only reads from standard input now

@briandfoy briandfoy self-assigned this Jun 4, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jun 4, 2024
@briandfoy briandfoy merged commit 2f29dec into briandfoy:master Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tr The tr program Status: accepted The fix is accepted Type: documentation fix the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy