Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ar: failed read() error #713

Merged
merged 1 commit into from
Aug 12, 2024
Merged

ar: failed read() error #713

merged 1 commit into from
Aug 12, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 12, 2024

  • After opening an archive, print $! if it wasn't possible to read the file
  • Now it's easier to tell between i/o errors and files which don't contain the magic number data
  • Conditionally declare $attr in printList() which is only needed for verbose mode
  • test1: "ar t ." --> directory error
  • test2: "perl ar t /bin/sh" --> file format error
  • test3: "perl ar t test.a" --> short listing of archive contents
  • test4: "perl ar tv test.a" --> detailed listing of archive contents

@mknos
ar: failed read() error
143e450 
* After opening an archive, print $! if it wasn't possible to read the file
* Now it's easier to tell between i/o errors and files which don't contain the magic number data
* Conditionally declare $attr in printList() which is only needed for verbose mode
* test1: "ar t ." --> directory error
* test2: "perl ar t /bin/sh" --> file format error
* test3: "perl ar t test.a" --> short listing of archive contents
* test4: "perl ar tv test.a" --> detailed listing of archive contents
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ar The ar program labels Aug 12, 2024
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 12, 2024 07:27 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10347664684

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.805%
Totals Coverage Status
Change from base Build 10316135952: 0.0%
Covered Lines: 355
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy merged commit 6569eab into briandfoy:master Aug 12, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: show system error when we can't read one of the files

@briandfoy briandfoy self-assigned this Aug 12, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ar The ar program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy