[filestore] Database binding for storing writes to the database in files #1053
Conversation
There was a problem hiding this comment.
Please place these into their own package.
What's an example of how one would use these files to load ycsb compatible data into a datastore? Since that's the listed purpose, it seems like we ought to have an example.
Given the stated purpose, why implement the run phase at all?
| } | ||
|
|
||
| /** | ||
| * Reads the file with the name {@code table}_{@code key}.json. |
There was a problem hiding this comment.
This layout is going to create directories that folks have a hard time managing with even modest datasets. if we must keep with one-file-per-key, then I'd suggest making directories within the data directory. Something like 3 or 4 layers based on a prefix of the key.
| } | ||
|
|
||
| private String getDatabaseFileName(String table, String key) { | ||
| return outputDirectory + table + "_" + key + ".json"; |
There was a problem hiding this comment.
How do I ensure that when I load these files into a datastore I'm doing it in the same order that YCSB generated them?
The idea for this binding is, to use the files for multiple benchmarks runs with different databases.
Using the exact same data should be good for consistency and makes the results more repeatable and reproducible.