Adding the ability to connect to Cassandra using SSL connections. #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stfeng2
reviewed
Apr 19, 2019
| if ((username != null) && !username.isEmpty()) { | ||
| cluster = Cluster.builder().withCredentials(username, password) | ||
| .withPort(Integer.valueOf(port)).addContactPoints(hosts).build(); | ||
| if (useSSL) { |
There was a problem hiding this comment.
Can these lines of code be merged into just a couple of lines like below?
clusterBuilder = Cluster.builder().with.....addContactPoints(hosts)
if (useSSL) ClusterBuilder = clusterBulider.withSSL()
Cluster = clusterBuilder.build()
There was a problem hiding this comment.
Sure let me try and optimize it.
stfeng2
reviewed
Apr 19, 2019
stfeng2
approved these changes
Apr 19, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to add a new flag called useSSL. It flag adds the ability to use secure connections. The default is "false" which is how the current driver connects. Personally I think the default should be secure connections but I dont want to break compatibility.